improve logging

Signed-off-by: Tim Vaillancourt <[email protected]>
timvaillancourt · Feb 10, 2025 · dcefb1f · dcefb1f
1 parent 9f6620d
commit dcefb1f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/go/vt/vtorc/logic/cell_discovery.go b/go/vt/vtorc/logic/cell_discovery.go
@@ -49,7 +49,7 @@ func refreshCells(cells []string) (err error) {
 	for _, cell := range cells {
 		err = inst.SaveCell(cell)
 		if err != nil {
-			log.Error(err)
+			log.Errorf("Failed to save cell %q: %+v", cell, err)
 			return err
 		}
 		updated[cell] = true
@@ -59,6 +59,7 @@ func refreshCells(cells []string) (err error) {
 	// be changing because we are holding a lock.
 	cells, err = inst.ReadCells()
 	if err != nil {
+		log.Errorf("Failed to read cells: %+v", err)
 		return err
 	}
 
@@ -69,7 +70,7 @@ func refreshCells(cells []string) (err error) {
 		}
 		log.Infof("Forgetting stale cell %q", cell)
 		if err = inst.DeleteCell(cell); err != nil {
-			return err
+			log.Errorf("Failed to delete cell %q: %+v", cell, err)
 		}
 	}
 	return nil

diff --git a/go/vt/vtorc/logic/cell_discovery_test.go b/go/vt/vtorc/logic/cell_discovery_test.go
@@ -27,7 +27,7 @@ import (
 	"vitess.io/vitess/go/vt/vtorc/inst"
 )
 
-func TestRefreshAllCells(t *testing.T) {
+func TestRefreshCells(t *testing.T) {
 	// Store the old flags and restore on test completion
 	oldTs := ts
 	defer func() {