From e08000a662d4d72b2afc2ae89a3cccff5d17d93e Mon Sep 17 00:00:00 2001 From: Tim Vaillancourt Date: Fri, 29 Mar 2024 01:59:29 +0100 Subject: [PATCH] move changelog to breaking changes Signed-off-by: Tim Vaillancourt --- changelog/20.0/20.0.0/summary.md | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/changelog/20.0/20.0.0/summary.md b/changelog/20.0/20.0.0/summary.md index f9b19a18307..3e12d594039 100644 --- a/changelog/20.0/20.0.0/summary.md +++ b/changelog/20.0/20.0.0/summary.md @@ -6,6 +6,7 @@ - **[Breaking changes](#breaking-changes)** - [`shutdown_grace_period` Default Change](#shutdown-grace-period-default) - [New `unmanaged` Flag and `disable_active_reparents` deprecation](#unmanaged-flag) + - [`Durabler` interface method renaming](#durabler-interface-method-renaming) - **[Query Compatibility](#query-compatibility)** - [Vindex Hints](#vindex-hints) - [Update with Limit Support](#update-limit) @@ -16,7 +17,6 @@ - **[Flag changes](#flag-changes)** - [`pprof-http` default change](#pprof-http-default) - [New `healthcheck-dial-concurrency` flag](#healthcheck-dial-concurrency-flag) - - **[`Durabler` interface method renaming](#durabler-interface-method-renaming)** - **[Minor Changes](#minor-changes)** - **[New Stats](#new-stats)** - [VTTablet Query Cache Hits and Misses](#vttablet-query-cache-hits-and-misses) @@ -39,6 +39,17 @@ New flag `--unmanaged` has been introduced in this release to make it easier to Starting this release, all unmanaged tablets should specify this flag. +#### `Durabler` interface method renaming + +The methods of [the `Durabler` interface](https://github.com/timvaillancourt/vitess/blob/main/go/vt/vtctl/reparentutil/durability.go#L70-L79) in `go/vt/vtctl/reparentutil` were renamed to be public _(capitalized)_ methods to make it easier to integrate custom Durability Policies from external packages. See [RFC for details](https://github.com/vitessio/vitess/issues/15544). + +Users of custom Durability Policies must rename private `Durabler` methods. + +Changes: +- The `promotionRule` method was renamed to `PromotionRule` +- The `semiSyncAckers` method was renamed to `SemiSyncAckers` +- The `isReplicaSemiSync` method was renamed to `IsReplicaSemiSync` + ### Query Compatibility #### Vindex Hints @@ -103,17 +114,6 @@ To continue enabling these endpoints, explicitly set `--pprof-http` when startin The new `--healthcheck-dial-concurrency` flag defines the maximum number of healthcheck connections that can open concurrently. This limit is to avoid hitting Go runtime panics on deployments watching enough tablets [to hit the runtime's maximum thread limit of `10000`](https://pkg.go.dev/runtime/debug#SetMaxThreads) due to blocking network syscalls. This flag applies to `vtcombo`, `vtctld` and `vtgate` only and a value less than the runtime max thread limit _(`10000`)_ is recommended. -### `Durabler` interface method renaming - -The methods of [the `Durabler` interface](https://github.com/timvaillancourt/vitess/blob/main/go/vt/vtctl/reparentutil/durability.go#L70-L79) in `go/vt/vtctl/reparentutil` were renamed to be public _(capitalized)_ methods to make it easier to integrate custom Durability Policies from external packages. See [RFC for details](https://github.com/vitessio/vitess/issues/15544). - -Users of custom Durability Policies must rename private `Durabler` methods. - -Changes: -- The `promotionRule` method was renamed to `PromotionRule` -- The `semiSyncAckers` method was renamed to `SemiSyncAckers` -- The `isReplicaSemiSync` method was renamed to `IsReplicaSemiSync` - ## Minor Changes ### New Stats