Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison Box – Creating a new block #2499

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

isaaclombardssw
Copy link
Contributor

@isaaclombardssw isaaclombardssw commented Nov 20, 2024

Some more null checks were needed so you can create a new comparison block. This fixes that.

Specifically images were trying to render with a null source, and the mapping is no longer needed to set defaults (criteria mapping is done on save).

This is a quick fix and there's more room for improvement (e.g. you need to put at least 4 or 5 companies and a couple criteria in before it looks "normal").

General Contributing:

All New Content Submissions: (To be confirmed by reviewer)

  • Title is short & specific
  • Headers are logically ordered & consistent
  • Purpose of document is explained in the first paragraph
  • Procedures are tested and work
  • Any technical concepts are explained or linked to
  • Document follows structure from templates
  • All links work
  • The spelling and grammar checker has been run
  • Graphics and images are clear and useful
  • Any prerequisites and next steps are defined.

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 9:47pm

Copy link
Contributor

@joshbermanssw joshbermanssw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - tested and it works

@isaaclombardssw isaaclombardssw merged commit bc147eb into main Nov 21, 2024
4 checks passed
@isaaclombardssw isaaclombardssw deleted the fixing-comparison-box branch November 21, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants