Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are 32-bit architectures supported? #19

Closed
dottedmag opened this issue May 9, 2024 · 3 comments
Closed

Are 32-bit architectures supported? #19

dottedmag opened this issue May 9, 2024 · 3 comments
Assignees

Comments

@dottedmag
Copy link

Describe the bug:

Trying to build Tink on 32-bit platforms (upstream Go 386 or tinygo wasm) fails:

% cat main.go
package main

import (
	"github.com/tink-crypto/tink-go/v2/aead"
)

func main() {
	aead.New(nil)
}
% GOOS=linux GOARCH=386 go build .
# github.com/tink-crypto/tink-go/v2/aead
../../../go/pkg/mod/github.com/tink-crypto/tink-go/[email protected]/aead/kms_envelope_aead.go:110:25: maxUint32Size (untyped int constant 4294967295) overflows int

What was the expected behavior?

% GOOS=linux GOARCH=386 go build .
%

What version of Tink are you using?

2.1.0

Is there anything else you'd like to add?

I haven't found a list of supported architectures anywhere in Tink documentation or source code.

@dottedmag
Copy link
Author

Also upstream Go is going to have 32-bit WebAssembly architecture, so this is not a theoretical issue: golang/go#63131

@juergw
Copy link
Contributor

juergw commented May 17, 2024

Thank you for bringing this up. Yes, we should certainly clarify this. I will add this to https://developers.google.com/tink/, and to the github.

We are only developing and testing on 64-bit architectures. So we don't even know what our code does on 32-bit architectures, and we can't give any guarantees. Making sure that all the code works correctly without any security problems on 32-bit would be a bigger effort, and we currently don't have any capacity to take on this project. I'm sorry.

@juergw juergw self-assigned this May 17, 2024
@juergw juergw removed their assignment Jun 13, 2024
@juergw
Copy link
Contributor

juergw commented Jun 19, 2024

I added this to the FAQ:

https://developers.google.com/tink/faq/support_for_32bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants