fix: toggle configuration reset after switch tab issue

tisfeng · Feb 2, 2024 · 4d14744 · 4d14744
1 parent 586b8ca
commit 4d14744
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/Easydict/NewApp/View/SettingView/Tabs/ServiceConfiguration/ServiceConfigurationCells.swift b/Easydict/NewApp/View/SettingView/Tabs/ServiceConfiguration/ServiceConfigurationCells.swift
@@ -73,22 +73,27 @@ struct ServiceConfigurationPickerCell<T: RawRepresentable & Hashable & EnumLocal
     }
 }
 
+class ConfigurationToggleViewModel: ObservableObject {
+    @Published var isOn = false
+}
+
 @available(macOS 13.0, *)
 struct ServiceConfigurationToggleCell: View {
     @Default var value: String
     let titleKey: LocalizedStringKey
-    @State private var isOn = false
+
+    @ObservedObject var viewModel = ConfigurationToggleViewModel()
 
     init(titleKey: LocalizedStringKey, key: Defaults.Key<String>) {
         self.titleKey = titleKey
         _value = .init(key)
-        _isOn = State(initialValue: value == "1")
+        viewModel.isOn = value == "1"
     }
 
     var body: some View {
-        Toggle(titleKey, isOn: $isOn)
+        Toggle(titleKey, isOn: $viewModel.isOn)
             .padding(10.0)
-            .onChange(of: isOn) { newValue in
+            .onChange(of: viewModel.isOn) { newValue in
                 value = newValue ? "1" : "0"
             }
     }

diff --git a/Easydict/NewApp/View/SettingView/Tabs/ServiceTab.swift b/Easydict/NewApp/View/SettingView/Tabs/ServiceTab.swift
@@ -64,9 +64,6 @@ struct ServiceTab: View {
                     }
                 }
             }
-            .onDisappear {
-                viewModel.selectedService = nil
-            }
             .layoutPriority(1)
         }
         .environmentObject(viewModel)