bugfix: remove increaseMenuItemHeight func (#318)

tisfeng · Jan 8, 2024 · 9433ee3 · 9433ee3
1 parent b336e30
commit 9433ee3
Showing 1 changed file with 0 additions and 22 deletions.
diff --git a/Easydict/Feature/StatusItem/EZMenuItemManager.m b/Easydict/Feature/StatusItem/EZMenuItemManager.m
@@ -98,7 +98,6 @@ - (void)setup {
     self.versionItem.title = self.versionTitle;
 
     NSArray *items = @[self.versionItem, self.settingsItem, self.checkForUpdateItem, self.helpItem, self.quitItem];
-    [self increaseMenuItemsHeight:items lineHeightRatio:kTitleMenuItemHeightRatio];
 
     [self updateVersionItem];
 }
@@ -308,8 +307,6 @@ - (void)menuWillOpen:(NSMenu *)menu {
             item.keyEquivalent = @"";
             item.keyEquivalentModifierMask = 0;
         }
-
-        [self increaseMenuItemHeight:item lineHeightRatio:kImageMenuItemHeightRatio];
     };
 
     configItemShortcut(self.selectionItem, EZSelectionShortcutKey);
@@ -319,24 +316,6 @@ - (void)menuWillOpen:(NSMenu *)menu {
     configItemShortcut(self.screenshotOCRItem, EZScreenshotOCRShortcutKey);
 }
 
-#pragma mark -
-
-/// Increase menu item height. Ref: https://stackoverflow.com/questions/18031666/nsmenuitem-height
-- (void)increaseMenuItemHeight:(NSMenuItem *)item lineHeightRatio:(CGFloat)lineHeightRatio {
-    NSFont *font = [NSFont systemFontOfSize:[NSFont systemFontSize]];
-    CGFloat fontLineHeight = (font.ascender + fabs(font.descender));
-    CGFloat lineHeight = fontLineHeight * lineHeightRatio;
-    // Ref stackoverflow: https://stackoverflow.com/a/18034142/8378840 
-    NSImage *image = [[NSImage alloc] initWithSize:NSMakeSize(1, lineHeight)];
-    [item setImage:image];
-}
-
-- (void)increaseMenuItemsHeight:(NSArray<NSMenuItem *> *)itmes lineHeightRatio:(CGFloat)lineHeightRatio {
-    for (NSMenuItem *item in itmes) {
-        [self increaseMenuItemHeight:item lineHeightRatio:lineHeightRatio];
-    }
-}
-
 #pragma mark - Fetch Github Repo Info
 
 - (void)updateVersionItem {
@@ -347,7 +326,6 @@ - (void)updateVersionItem {
             versionTitle = [NSString stringWithFormat:@"%@  (✨ %@)", self.versionTitle, lastestVersion];
         }
         self.versionItem.title = versionTitle;
-        [self increaseMenuItemHeight:self.versionItem lineHeightRatio:kTitleMenuItemHeightRatio];
     }];
 }