From 707de748041152b6e2d3ee8b37ad9caead9da282 Mon Sep 17 00:00:00 2001 From: tisfeng Date: Fri, 3 May 2024 11:19:50 +0800 Subject: [PATCH 1/2] perf: add show floating window log --- .../Window/BaseQueryWindow/EZBaseQueryViewController.m | 2 +- .../ViewController/Window/WindowManager/EZWindowManager.m | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m b/Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m index a1f7fdf25..7620423f1 100644 --- a/Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m +++ b/Easydict/objc/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m @@ -434,7 +434,7 @@ - (void)postUpdateServiceNotification { } - (void)startOCRImage:(NSImage *)image actionType:(EZActionType)actionType { - MMLogInfo(@"start OCR Image"); + MMLogInfo(@"start OCR Image: %@, actionType: %@", @(image.size), actionType); self.queryModel.OCRImage = image; self.queryModel.actionType = actionType; diff --git a/Easydict/objc/ViewController/Window/WindowManager/EZWindowManager.m b/Easydict/objc/ViewController/Window/WindowManager/EZWindowManager.m index f1bae5f29..b45f17102 100644 --- a/Easydict/objc/ViewController/Window/WindowManager/EZWindowManager.m +++ b/Easydict/objc/ViewController/Window/WindowManager/EZWindowManager.m @@ -311,6 +311,8 @@ - (void)showFloatingWindowType:(EZWindowType)windowType self.selectedText = queryText; self.actionType = actionType; + MMLogInfo(@"show floating windowType: %ld, queryText: %@, autoQuery: %d, actionType: %@, atPoint: %@", windowType, queryText, autoQuery, actionType, @(point)); + // Update isTextEditable value when using invoke query, such as open URL Scheme by PopClip. if (actionType == EZActionTypeInvokeQuery) { [self.eventMonitor updateSelectedTextEditableState]; @@ -762,8 +764,9 @@ - (void)snipTranslate { // Reset window height first, avoid being affected by previous window height. [window.queryViewController resetTableView:^{ + self.actionType = EZActionTypeOCRQuery; [self showFloatingWindowType:windowType queryText:nil]; - [window.queryViewController startOCRImage:image actionType:EZActionTypeOCRQuery]; + [window.queryViewController startOCRImage:image actionType:self.actionType]; }]; }]; }); From 5800e14b48fe1c3addf5e435a6ea669cb6c50f1e Mon Sep 17 00:00:00 2001 From: tisfeng Date: Sat, 4 May 2024 21:16:57 +0800 Subject: [PATCH 2/2] docs: update README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5ef54e342..2e62f526a 100644 --- a/README.md +++ b/README.md @@ -584,7 +584,7 @@ Easydict 可以根据查询文本的内容，自动启用相应的查询服务 具体来说，在智能查询模式下，当查询单词时，则只会调用支持【单词查询】的服务；当翻译文本时，则只会调用支持【文本翻译】的服务。 -对于单词，支持查询单词的服务效果明显比翻译更好，而翻译文本时，启用单词查询服务 +对于单词查询，支持查询单词服务的效果明显比简单翻译更好，例如苹果词典和有道词典；而进行长文本翻译时，启用单词查询服务没有意义，例如使用苹果词典来翻译。 默认情况下，所有的翻译服务都支持单词查询（单词也属于文本的一种），用户可以手动调整，如设置 Google 智能模式只翻译文本，只需要使用下面命令修改为 `translation | sentence` 即可。