From a2cc86277b9ea15d299afeb1dde8b961982b9908 Mon Sep 17 00:00:00 2001
From: phlpsong <103433299+phlpsong@users.noreply.github.com>
Date: Wed, 24 Jan 2024 16:57:11 +0800
Subject: [PATCH] fix: General tab other section title (#361)

* fix: general tab other title issue

* fix: other translation
---
 Easydict/App/Localizable.xcstrings            | 29 ++++++++++++-------
 .../View/SettingView/Tabs/GeneralTab.swift    |  2 +-
 2 files changed, 19 insertions(+), 12 deletions(-)

diff --git a/Easydict/App/Localizable.xcstrings b/Easydict/App/Localizable.xcstrings
index d96c42854..bb3696775 100644
--- a/Easydict/App/Localizable.xcstrings
+++ b/Easydict/App/Localizable.xcstrings
@@ -1958,16 +1958,6 @@
         }
       }
     },
-    "other" : {
-      "localizations" : {
-        "zh-Hans" : {
-          "stringUnit" : {
-            "state" : "translated",
-            "value" : "其他"
-          }
-        }
-      }
-    },
     "Parameter Error" : {
       "comment" : "Error description",
       "localizations" : {
@@ -2772,6 +2762,23 @@
         }
       }
     },
+    "setting.general.other.header" : {
+      "extractionState" : "manual",
+      "localizations" : {
+        "en" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "Other"
+          }
+        },
+        "zh-Hans" : {
+          "stringUnit" : {
+            "state" : "translated",
+            "value" : "其他"
+          }
+        }
+      }
+    },
     "setting.general.quick_link.header" : {
       "localizations" : {
         "en" : {
@@ -3443,4 +3450,4 @@
     }
   },
   "version" : "1.0"
-}
\ No newline at end of file
+}
diff --git a/Easydict/NewApp/View/SettingView/Tabs/GeneralTab.swift b/Easydict/NewApp/View/SettingView/Tabs/GeneralTab.swift
index 6471771c1..26e427fee 100644
--- a/Easydict/NewApp/View/SettingView/Tabs/GeneralTab.swift
+++ b/Easydict/NewApp/View/SettingView/Tabs/GeneralTab.swift
@@ -137,7 +137,7 @@ struct GeneralTab: View {
                     Text("hide_menu_bar_icon")
                 }
             } header: {
-                Text("other")
+                Text("setting.general.other.header")
             }
         }
         .formStyle(.grouped)