pref: optimize code

tisfeng · Feb 7, 2024 · b338c15 · b338c15
1 parent fc3b429
commit b338c15
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/Easydict/NewApp/Feature/Shortcut/Shortcut+Menu.swift b/Easydict/NewApp/Feature/Shortcut/Shortcut+Menu.swift
@@ -10,7 +10,7 @@ import SwiftUI
 
 extension Shortcut {
     func updateMenu(_ type: ShortcutType) { // update shortcut menu
-        let shortcutTitle = String.localizedString(for: LocalizedStringKey(type.localizedStringKey()).stringKey ?? "")
+        let shortcutTitle = LocalizedStringKey(type.localizedStringKey()).stringValue()
         let shortcutMenu = NSApp.mainMenu?.items.first(where: { $0.title == "Shortcut" })
         let clearInput = shortcutMenu?.submenu?.items.first(where: { $0.title == shortcutTitle })
         clearInput?.keyEquivalent = ""

diff --git a/Easydict/NewApp/Utility/Extensions/String/String+Localized.swift b/Easydict/NewApp/Utility/Extensions/String/String+Localized.swift
@@ -17,6 +17,10 @@ extension LocalizedStringKey {
     var stringKey: String? {
         Mirror(reflecting: self).children.first(where: { $0.label == "key" })?.value as? String
     }
+
+    func stringValue(locale: Locale = .current) -> String {
+        .localizedString(for: stringKey ?? "", locale: locale)
+    }
 }
 
 extension String {