From f175d2093e4917f02c93e985a54fda8b17e27f21 Mon Sep 17 00:00:00 2001 From: NeverAgain11 Date: Thu, 15 Feb 2024 17:43:52 +0800 Subject: [PATCH 1/3] Set launchAtStartUp only on value change. (#409) Co-authored-by: Tisfeng --- Easydict/Feature/Configuration/Configuration.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Easydict/Feature/Configuration/Configuration.swift b/Easydict/Feature/Configuration/Configuration.swift index 774f4a193..3a841c681 100644 --- a/Easydict/Feature/Configuration/Configuration.swift +++ b/Easydict/Feature/Configuration/Configuration.swift @@ -220,7 +220,7 @@ let kHideMenuBarIconKey = "EZConfiguration_kHideMenuBarIconKey" ) cancellables.append( - Defaults.publisher(.launchAtStartup) + Defaults.publisher(.launchAtStartup, options: []) .removeDuplicates() .sink { [weak self] change in self?.didSetLaunchAtStartup(change.oldValue, new: change.newValue) From 5e06840d6d2e3ca8f3c52c25b48a68608530e3ba Mon Sep 17 00:00:00 2001 From: tisfeng Date: Thu, 15 Feb 2024 18:15:24 +0800 Subject: [PATCH 2/3] chore: try to remove xcode version --- .github/workflows/codeql.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 0646af483..bfaee7a03 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -44,12 +44,6 @@ jobs: # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support steps: - - name: Setup Xcode Version - if: matrix.language == 'swift' - uses: maxim-lobanov/setup-xcode@v1 - with: - xcode-version: '15.2' - - name: Checkout repository uses: actions/checkout@v4 From 37538b857491bb0a48c2d49f1db8913cab3478cd Mon Sep 17 00:00:00 2001 From: tisfeng Date: Thu, 15 Feb 2024 18:52:04 +0800 Subject: [PATCH 3/3] Revert "chore: update codeql.yml, change image to macos-14.2 and xcode-version to 15.2" This reverts commit 1202c3f95be97208e41da6b042b763fac6643d2f. --- .github/workflows/codeql.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index bfaee7a03..047dd13b3 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -27,7 +27,7 @@ jobs: # - https://gh.io/supported-runners-and-hardware-resources # - https://gh.io/using-larger-runners # Consider using larger runners for possible analysis time improvements. - runs-on: ${{ (matrix.language == 'swift' && 'macos-14') || 'ubuntu-latest' }} + runs-on: ${{ (matrix.language == 'swift' && 'macos-13') || 'ubuntu-latest' }} timeout-minutes: ${{ (matrix.language == 'swift' && 120) || 360 }} permissions: actions: read @@ -44,6 +44,12 @@ jobs: # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support steps: + - name: Setup Xcode Version + if: matrix.language == 'swift' + uses: maxim-lobanov/setup-xcode@v1 + with: + xcode-version: '15.1' + - name: Checkout repository uses: actions/checkout@v4