Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature Request: Microsoft Bing Translator #143

Closed
3 of 4 tasks
Svec-Tomas opened this issue Jul 16, 2023 · 17 comments · Fixed by #161
Closed
3 of 4 tasks

🚀 Feature Request: Microsoft Bing Translator #143

Svec-Tomas opened this issue Jul 16, 2023 · 17 comments · Fixed by #161
Assignees
Labels
enhancement New feature or request fixed in next release The issue will be closed once next release is available

Comments

@Svec-Tomas
Copy link
Contributor

Please confirm the following:

  • I have carefully read the README
  • I have searched through the issues page and didn't find a similar feature request.(Including issue that has been closed)
  • Easydict has been upgraded to the latest version.

Feature description

I would love to add if possible Microsoft Bing Translator. There should be available free API here:

https://github.com/plainheart/bing-translate-api

Use case (optional)

From my experience I get the best translation results from DeepL and then on second place is Bing Translator. I am using English to Slovak most of the time.

Proposed solution (optional)

I didn't see anyone before asking for this in english. Also not sure if Google Bard has any free API, if so, it would be great to have it included as well!

Are you willing to submit a PR to implement this feature

  • I'm willing to submit PR!
@Svec-Tomas Svec-Tomas added the enhancement New feature or request label Jul 16, 2023
@github-actions
Copy link

Hello Svec-Tomas, Thank you for your first issue contribution 🎉

@Svec-Tomas Svec-Tomas changed the title 🚀 Feature Request: Please fill in the title 🚀 Feature Request: Microsoft Bing Translator Jul 16, 2023
@Jerry23011
Copy link
Collaborator

Also not sure if Google Bard has any free API

Google Bard doesn't provide API access at the moment.

@tisfeng
Copy link
Owner

tisfeng commented Jul 16, 2023

@Svec-Tomas Bing Translator is OK, if you can submit a PR, I will be happy to accept it.

In addition, Google has Generative Al PaLM, but you need to apply for a waitlist . This seems very interesting, and I am looking forward to your PR.

@Svec-Tomas
Copy link
Contributor Author

I will check how to submit a PR, as it will be first time for me, I have never done it before. Thanks a lot tisfeng!

@Svec-Tomas
Copy link
Contributor Author

I am really lost, can you or someone please guide me how to submit a PR?

@Jerry23011
Copy link
Collaborator

I am really lost, can you or someone please guide me how to submit a PR?

Can you code in Objective-C? Submitting a PR means to contribute code to this project.

@Svec-Tomas
Copy link
Contributor Author

No, I really can not code, sorry. I am just an ordinary user, who wanted to have there also Bing Translator. That's why I did not understand probably how to submit a Pull Request :(

@Svec-Tomas
Copy link
Contributor Author

Can someone else do it instead of me, please?

@tisfeng
Copy link
Owner

tisfeng commented Jul 17, 2023

That's regretful. The languages ​​I mainly use at present are Chinese and English. For me, Google and DeepL are already working very well, and I don’t have the energy to add other services for the time being.

It is definitely good to support more services, so I hope to receive PRs that support other translation services. PRs from any partners are welcome.

@tisfeng
Copy link
Owner

tisfeng commented Jul 17, 2023

@choikarl Are you interested in this feature? If interested, take a look, there's no time rush.

@choykarl
Copy link
Collaborator

@choikarl Are you interested in this feature? If interested, take a look, there's no time rush.

@tisfeng 公司G了,接下来要准备换工作和漫长的找工作过程🤣,人麻了,要是对时间不care的话,我可以看看。

@tisfeng
Copy link
Owner

tisfeng commented Jul 18, 2023

@choikarl 默哀,,这个功能不着急,那就交给你了。

@tisfeng
Copy link
Owner

tisfeng commented Jul 18, 2023

Hi, @Svec-Tomas

Another partner @choikarl has taken over this feature and he will submit the PR later.

@Svec-Tomas
Copy link
Contributor Author

Thanks a lot to everyone! 👍

@Jerry23011 Jerry23011 linked a pull request Aug 14, 2023 that will close this issue
@tisfeng tisfeng added the fixed in next release The issue will be closed once next release is available label Aug 15, 2023
@tisfeng
Copy link
Owner

tisfeng commented Aug 15, 2023

This feature has been completed by @choikarl #161 , and will be released in the next version.

@Svec-Tomas
Copy link
Contributor Author

That's fantastic, thanks a lot! 🙏😍

@tisfeng
Copy link
Owner

tisfeng commented Oct 25, 2023

Hi, the 2.0.1 version has Bing translation support.

@tisfeng tisfeng closed this as completed Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in next release The issue will be closed once next release is available
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants