Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Bug Report: auto selecting icon in firefox not working #166

Closed
3 of 4 tasks
roohino opened this issue Aug 17, 2023 · 7 comments
Closed
3 of 4 tasks

🐞 Bug Report: auto selecting icon in firefox not working #166

roohino opened this issue Aug 17, 2023 · 7 comments
Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available

Comments

@roohino
Copy link

roohino commented Aug 17, 2023

Please confirm the following:

  • I have carefully read the README
  • I have searched through the issues page but couldn't find a solution.(Including issue that has been closed)
  • Easydict has been upgraded to the latest version.

Problem description

Hello
I really liked this app, but I have got problem. in Firefox when I select text mini icon not shows. in safari and chrome every thing is fine.

Reproduction steps

in firefox When I select the text hover icon not working

Expected result

I wanna shows hover icon after I selected a text

Proposed solution (optional)

No response

Device information and OS version

No response

Are you willing to submit a PR to fix this issue?

  • I'm willing to submit a PR!
@roohino roohino added the bug Something isn't working label Aug 17, 2023
@github-actions
Copy link

Hello roohino, Thank you for your first issue contribution 🎉

@tisfeng
Copy link
Owner

tisfeng commented Aug 20, 2023

@roohino Hi

Please make sure that you have enabled the auxiliary function permission for Easydict.

Sometimes, due to system bugs, even if you turn on accessibility, it won't work properly, so you need to remove the option and manually click the + in the bottom-left corner to re-add Easydict.

In addition, Safari and Chrome also support AppleScript to fetch words in addition to system Accessibility, but unfortunately Firefox doesn't support it.

image

@c3qo
Copy link
Contributor

c3qo commented Sep 1, 2023

Got the similar issue, EasyDict doesn't work for firefox. Following other similar fixing, I added firefox bundle id org.mozilla.firefox to kAXErrorAttributeUnsupported and enabled the setting: Force get selected text .... (Experimental), it works now.

Let me know if you prefer to fixing it by yourself or I can send a PR. @tisfeng

Good tool, thank you.

@tisfeng
Copy link
Owner

tisfeng commented Sep 2, 2023

@moroumo Of course, you can submit PRs to the dev branch.

Firefox is one of those special apps that works fine on my computer, but not on some users' computers, like yours 🥲

@tisfeng tisfeng added the fixed in next release The issue will be closed once next release is available label Sep 7, 2023
@tisfeng
Copy link
Owner

tisfeng commented Oct 25, 2023

Hi, the 2.0.1 version has fixed the issue.

@tisfeng tisfeng closed this as completed Oct 25, 2023
@truebit
Copy link

truebit commented Aug 30, 2024

firefox 129.0.2 又不行了。好像是easydict更新后的问题

@tisfeng
Copy link
Owner

tisfeng commented Aug 30, 2024

请尝试开启【强制划词】 #640 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available
Projects
None yet
Development

No branches or pull requests

4 participants