Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 功能建议:新增的翻译服务能否默认关闭,并且排序在末尾 #269

Closed
3 of 4 tasks
jh-leong opened this issue Dec 19, 2023 · 7 comments
Closed
3 of 4 tasks
Assignees
Labels
enhancement New feature or request fixed in next release The issue will be closed once next release is available good first issue Good for newcomers

Comments

@jh-leong
Copy link

请先确认以下事项

  • 已仔细阅读了 README
  • issues 页面搜索过(包括已关闭的 issue),未发现类似功能建议
  • Easydict 已升级到 最新版本

功能描述

问题:在每一次更新中,如果新增了翻译服务,新增的服务都会默认开启,并且在服务排序中置顶;
影响:影响用户原有的设置,导致每次更新都要重新去设置中关闭和排序;
期望:新增的翻译服务默认关闭,并且排序在末尾

使用场景(可选)

No response

实现方案(可选)

No response

是否愿意提交 PR 实现该功能

  • 我愿意提交 PR
@jh-leong jh-leong added the enhancement New feature or request label Dec 19, 2023
Copy link

Hello jh-leong, Thank you for your first issue contribution 🎉

@tisfeng
Copy link
Owner

tisfeng commented Dec 19, 2023

可以,后面我改一下。

@tisfeng tisfeng added good first issue Good for newcomers fixed in next release The issue will be closed once next release is available labels Dec 19, 2023
@AkaShark
Copy link
Collaborator

Hi I am interested in this project, and I used Bob before. If this issue is open? Can I try to add this feature?

@tisfeng
Copy link
Owner

tisfeng commented Dec 24, 2023

Thank you for your interest, this feature is already implemented, if you are interested in this project, you can help with other issues, especially the ones with the PR wanted tag.

@AkaShark
Copy link
Collaborator

okay~

@tisfeng tisfeng self-assigned this Dec 25, 2023
@tisfeng
Copy link
Owner

tisfeng commented Jan 5, 2024

发布后才发现,2.5.0 版本好像改错了,对于新增的翻译服务,我本来想改成默认关闭查询功能,结果改成默认关闭显示,得用户自己去设置页添加了 😢

问题也不大,后面我再改改。

@tisfeng
Copy link
Owner

tisfeng commented Feb 9, 2024

2.6.0 新版本已修复该问题。

@tisfeng tisfeng closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in next release The issue will be closed once next release is available good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants