Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Swift 重构】使用 Swift 重写 EZConfiguration #284

Closed
Tracked by #285
tisfeng opened this issue Dec 29, 2023 · 6 comments
Closed
Tracked by #285

【Swift 重构】使用 Swift 重写 EZConfiguration #284

tisfeng opened this issue Dec 29, 2023 · 6 comments
Assignees
Labels

Comments

@tisfeng
Copy link
Owner

tisfeng commented Dec 29, 2023

参见 #283 (comment)

@tisfeng tisfeng added the dev label Dec 29, 2023
@NeverAgain11
Copy link
Collaborator

我可以,不过最近有点事,可能会慢点。

@tisfeng
Copy link
Owner Author

tisfeng commented Dec 30, 2023

ok

@tisfeng tisfeng changed the title Swift Refactor:使用 Swift 重写 EZConfiguration 【Swift 重构】使用 Swift 重写 EZConfiguration Dec 30, 2023
@tisfeng
Copy link
Owner Author

tisfeng commented Jan 13, 2024

你好,这个 PR #323 计划引入第三方库 Defaults 来管理保存设置项,EZConfiguration 可能也需要作出一些修改,你看一下有没有什么问题。

@NeverAgain11
Copy link
Collaborator

没啥问题,EZConfiguration 里面有很多 log 打印,还需要吗

@tisfeng
Copy link
Owner Author

tisfeng commented Jan 14, 2024

和之前保持一致就行,有时候会需要一些统计信息,例如用户的偏好语言,如果使用某个语言的用户人数较多,我们的代码可以考虑针对这个语言优化一下,以及提供本地化语言支持等。

@tisfeng
Copy link
Owner Author

tisfeng commented Jan 14, 2024

这个 PR #323 我已经合并了,你可能需要实现观察各个 key 的改变 https://github.com/sindresorhus/Defaults?tab=readme-ov-file#observe-changes-to-a-key ,确保修改 key 值后会执行对应的事件。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants