Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Bug Report: query window dismissed before showing the result in Stage Manager mode #381

Closed
5 tasks done
phlpsong opened this issue Feb 2, 2024 · 3 comments
Closed
5 tasks done
Assignees
Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available

Comments

@phlpsong
Copy link
Collaborator

phlpsong commented Feb 2, 2024

Please confirm the following:

  • I have carefully read the README
  • I have searched through the issues page but couldn't find a solution.(Including issue that has been closed)
  • Easydict has been upgraded to the latest version
  • I understand and agree to the above, and understand that the project maintainer has limited energy, issues that do not follow the rules may be ignored or closed directly

Problem description

query window dismissed before showing the result in Stage Manager mode

Reproduction steps

  1. Enable Stage Manager mode in system settings and unchecked Hide main window at startup
  2. Select text to query

Screenshot

Screen.Recording.2024-02-02.at.22.48.55.mov

Expected result

The query window stays visible

Proposed solution (optional)

No response

Device type and OS version

macOS 14.2.1

Are you willing to submit a PR to fix this issue?

  • I'm willing to submit a PR
@phlpsong phlpsong added the bug Something isn't working label Feb 2, 2024
@phlpsong
Copy link
Collaborator Author

phlpsong commented Feb 2, 2024

I noticed that we check [EZMainQueryWindow isAlive] twice in the showFloatingWindow function of EZWindowManager and then perform orderOut and orderBack on the mainWindow.

Is it necessary to have the subsequent orderBack?

@tisfeng
Copy link
Owner

tisfeng commented Feb 2, 2024

Currently the window management in the code is confusing, it needs to be improved #362 , but I'm not too familiar with this.

Previously I found that if the main window is turned on, when displaying the mini query window, the main window needs to be hidden first for a better user experience, if don't call orderBack, we can't see main window any more. But now I tested it and it seems to work without orderBack, which is strange.

I haven't tested this in Stage Manager mode before, you can try to fix this as you see fit.

@tisfeng tisfeng added the fixed in next release The issue will be closed once next release is available label Feb 4, 2024
@tisfeng
Copy link
Owner

tisfeng commented Feb 9, 2024

2.6.0 新版本已修复该问题。

@tisfeng tisfeng closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next release The issue will be closed once next release is available
Projects
None yet
Development

No branches or pull requests

2 participants