Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature Request: Support eudic2 shortcut #454

Closed
5 tasks done
Roiocam opened this issue Mar 13, 2024 · 5 comments
Closed
5 tasks done

🚀 Feature Request: Support eudic2 shortcut #454

Roiocam opened this issue Mar 13, 2024 · 5 comments
Assignees
@Roiocam
Labels
enhancement New feature or request fixed in next release The issue will be closed once next release is available

Comments

@Roiocam
Copy link
Contributor

Roiocam commented Mar 13, 2024 •
edited
Loading

Please confirm the following:

  • I have carefully read the README
  • I have searched through the issues page and didn't find a similar feature request.(Including issue that has been closed)
  • Easydict has been upgraded to the latest version
  • I understand and agree to the above, and understand that the project maintainer has limited energy, issues that do not follow the rules may be ignored or closed directly

Feature description

截屏2024-03-13 13 42 52

Use case

We already have eudic shortcut, it will be great that support eudic2 too.

截屏2024-03-13 13 44 15

Proposed solution (optional)

No response

Are you willing to submit a PR to implement this feature

  • I'm willing to submit PR
@Roiocam Roiocam added the enhancement New feature or request label Mar 13, 2024
@github-actions GitHub Actions
Copy link

Hello Roiocam, Thank you for your first issue contribution 🎉

@Roiocam
Copy link
Contributor Author

Roiocam commented Mar 13, 2024

I will be trying to resolve this issue later.

@Roiocam Roiocam mentioned this issue Mar 13, 2024
Merged
@Roiocam
Copy link
Contributor Author

Roiocam commented Mar 13, 2024

Solved in #455

@tisfeng tisfeng added the fixed in next release The issue will be closed once next release is available label Mar 14, 2024
@Roiocam Roiocam closed this as completed Mar 14, 2024
@tisfeng
Copy link
Owner

tisfeng commented Mar 14, 2024

Let’s leave it open, I will close it when the next version is updated.

@tisfeng tisfeng reopened this Mar 14, 2024
@tisfeng
Copy link
Owner

tisfeng commented May 1, 2024

2.7.0 版本已实现该功能。

@tisfeng tisfeng closed this as completed May 1, 2024
@Roiocam Roiocam mentioned this issue May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Roiocam Roiocam

Labels
enhancement New feature or request fixed in next release The issue will be closed once next release is available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tisfeng @Roiocam