Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: General tab other section title #361

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

phlpsong
Copy link
Collaborator

No description provided.

Jerry23011
Jerry23011 previously approved these changes Jan 24, 2024
Copy link
Collaborator

@Jerry23011 Jerry23011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could think twice if we want the gender neutral pronoun “其它“. Apple’s official Simplified Chinese localization adopts “其他”. LGTM never the less.

@phlpsong
Copy link
Collaborator Author

We could think twice if we want the gender neutral pronoun “其它“. Apple’s official Simplified Chinese localization adopts “其他”. LGTM never the less.

Good point! I checked some articles, 其他 is more accurate.

@tisfeng tisfeng merged commit a2cc862 into tisfeng:dev Jan 24, 2024
5 checks passed
@phlpsong phlpsong deleted the general_other_title branch January 24, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants