Add Traditional Chinese to TencentTranslateType dev #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerry23011
requested review from
NeverAgain11,
choykarl,
tisfeng,
AkaShark,
CanglongCl and
phlpsong
CanglongCl
previously approved these changes
Jan 26, 2024
phlpsong
previously approved these changes
Jan 26, 2024
AkaShark
previously approved these changes
Jan 26, 2024
tisfeng
dismissed stale reviews from AkaShark, phlpsong, and CanglongCl
via
4580d35
|
I improved the check condition, please review the code and test it again. |
AkaShark
approved these changes
Jan 26, 2024
LGTM |
CanglongCl
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since simplified & traditional Chinese are still not labeled as translatable to each other on the doc. I didn't remove the logic in transType so that these two can still be usable.
Closes #367