From de9490b41a56cbc5a2b61ae18acbd3a0785ad7f1 Mon Sep 17 00:00:00 2001
From: titigmr <thierry.gmr@outlook.fr>
Date: Wed, 14 Aug 2024 15:37:00 +0200
Subject: [PATCH 1/2] fix: :sparkles: change default values and entrypoint

---
 Dockerfile |  2 +-
 README.md  | 10 +++++-----
 main.go    |  4 ++--
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index 0e5370a..7ecfb8a 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -21,4 +21,4 @@ RUN CGO_ENABLED=${CGO_ENABLED} GOOS=${TARGETOS} GOARCH=${TARGETARCH} \
 FROM gcr.io/distroless/static-debian12:nonroot AS prod
 
 COPY --from=build /go/bin/app /
-CMD ["/app"]
\ No newline at end of file
+ENTRYPOINT ["/app"]
\ No newline at end of file
diff --git a/README.md b/README.md
index 5bf0f27..58179c1 100644
--- a/README.md
+++ b/README.md
@@ -17,9 +17,11 @@ helm repo add external-dns https://kubernetes-sigs.github.io/external-dns/
 1. Create the helm values file `external-dns-midaas-values.yaml`:
 
 ```yaml
-# if midaas can delete records in dns zone
+# -- How DNS records are synchronized between sources and providers; available values are `sync` & `upsert-only`.
 policy: sync
-# midaas manage all records on zone
+# -- Specify the registry for storing ownership and labels.
+# Valid values are `txt`, `aws-sd`, `dynamodb` & `noop`.
+# If `noop` midaas manage all records on zone
 registry: noop
 # can restrict zone
 domainFilters: ["subzone.dev.example.com"]
@@ -27,10 +29,8 @@ provider:
   name: webhook
   webhook: 
     image: ghcr.io/titigmr/external-dns-midaas-webhook
-    tag: v1.0.0
+    tag: latest
   env:
-  - name: PROVIDER_SKIP_TLS_VERIFY
-    value: "true"
   - name: PROVIDER_DNS_ZONE_SUFFIX
     value: "dev.example.com"
   - name: PROVIDER_WS_URL
diff --git a/main.go b/main.go
index 65ea866..2af6896 100644
--- a/main.go
+++ b/main.go
@@ -16,8 +16,8 @@ import (
 
 type Config struct {
 	Server struct {
-		Port string `envconfig:"API_SERVER_PORT" default:"6666"`
-		Host string `envconfig:"API_SERVER_HOST" default:"127.0.0.1"`
+		Port string `envconfig:"API_SERVER_PORT" default:"8888"`
+		Host string `envconfig:"API_SERVER_HOST" default:"0.0.0.0"`
 	}
 	Options struct {
 		ReadTimeout  time.Duration `envconfig:"API_READ_TIMEOUT"   default:"3s"`

From c55b294cc99e6f790582ba4518571d814dade74a Mon Sep 17 00:00:00 2001
From: titigmr <thierry.gmr@outlook.fr>
Date: Wed, 14 Aug 2024 15:57:21 +0200
Subject: [PATCH 2/2] ci: :sparkles: add checkout on test ci

---
 .github/workflows/test.yml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 74c077e..e46e42a 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -22,6 +22,9 @@ jobs:
     name: Test application
     runs-on: ubuntu-latest
     steps:
+      - name: Checks-out repository
+        uses: actions/checkout@v4
+
       - name: Setup Go
         uses: actions/setup-go@v5
         with: