Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ✨ change default values and entrypoint #25

Merged
merged 2 commits into from
Aug 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ jobs:
name: Test application
runs-on: ubuntu-latest
steps:
- name: Checks-out repository
uses: actions/checkout@v4

- name: Setup Go
uses: actions/setup-go@v5
with:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ RUN CGO_ENABLED=${CGO_ENABLED} GOOS=${TARGETOS} GOARCH=${TARGETARCH} \
FROM gcr.io/distroless/static-debian12:nonroot AS prod

COPY --from=build /go/bin/app /
CMD ["/app"]
ENTRYPOINT ["/app"]
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,20 @@ helm repo add external-dns https://kubernetes-sigs.github.io/external-dns/
1. Create the helm values file `external-dns-midaas-values.yaml`:

```yaml
# if midaas can delete records in dns zone
# -- How DNS records are synchronized between sources and providers; available values are `sync` & `upsert-only`.
policy: sync
# midaas manage all records on zone
# -- Specify the registry for storing ownership and labels.
# Valid values are `txt`, `aws-sd`, `dynamodb` & `noop`.
# If `noop` midaas manage all records on zone
registry: noop
# can restrict zone
domainFilters: ["subzone.dev.example.com"]
provider:
name: webhook
webhook:
image: ghcr.io/titigmr/external-dns-midaas-webhook
tag: v1.0.0
tag: latest
env:
- name: PROVIDER_SKIP_TLS_VERIFY
value: "true"
- name: PROVIDER_DNS_ZONE_SUFFIX
value: "dev.example.com"
- name: PROVIDER_WS_URL
Expand Down
4 changes: 2 additions & 2 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import (

type Config struct {
Server struct {
Port string `envconfig:"API_SERVER_PORT" default:"6666"`
Host string `envconfig:"API_SERVER_HOST" default:"127.0.0.1"`
Port string `envconfig:"API_SERVER_PORT" default:"8888"`
Host string `envconfig:"API_SERVER_HOST" default:"0.0.0.0"`
}
Options struct {
ReadTimeout time.Duration `envconfig:"API_READ_TIMEOUT" default:"3s"`
Expand Down