Matching directories with inner directories #1947

laysauchoa · 2024-02-20T18:07:05Z

laysauchoa
Feb 20, 2024

Hi @jackton1 Thank you for this great action. I need some help to understand how to use the action for the following case:

I want to get changes only in a specific level of a directory that has inner directories.

├── A1
│   └── B
│       └── C
│           └── D
│               ├── hello.txt
│               └── bye.txt

Case 1) For example, if I rename B to new-B, I'd like to have the output as:

created:

A/new-B/

deleted:

A/B/

updated:

A/new-B

What I tried:

      - name: Get changed files
        id: changed-files
        uses: tj-actions/changed-files@v42
        with:
          output_renamed_files_as_deleted_and_added: true
          dir_names: true
          dir_names_deleted_files_include_only_deleted_dirs: true
          files: A/**/

Case 2) If I rename C to new-C, I want to have as output:

created:

A/B/new-C

deleted:

A/B/C

updated:

A/B/new-C

What I tried:

      - name: Get changed files
        id: changed-files
        uses: tj-actions/changed-files@v42
        with:
          output_renamed_files_as_deleted_and_added: true
          dir_names: true
          dir_names_deleted_files_include_only_deleted_dirs: true
          files: A/**/**/

I also tried dir_names_max_depth but this only affects the output not the track so it could track a change on path A/B/C/D and have a shorter output as A/B/ and so on. What would you advise in this case? Does it support regex?

Answered by jackton1

Feb 23, 2024

A folder rename should be considered from the file level not the folder level. Renaming a file tracked by git is similar to changing the folder the file was in e.g A/b.txt renaming A to B simply means the location is now B/b.txt which gets tracked as a move if b.txt is not changed or a delete and create if the contents of b.txt has changed. The phrase “So the action will not track folder rename only” again is incorrect git tracks files not folders I.e content changes.

This action uses git to output the list of tracked changed files i.e b.txt you can optionally output only the directory name which is done by dir_names input. In the example above if it’s a directory rename A/b.txt -> B/b.tx…

View full answer

jackton1 · 2024-02-20T19:27:19Z

jackton1
Feb 20, 2024
Maintainer

Hi @laysauchoa it would be helpful to provide the output of what you tried. You'll need to re-run the workflow and enable debug mode which generates more information and you can grab the related outputs.

Just looking at the steps you provided however I'll suggest not ending patterns with a slash. You can test glob patterns here

Example

VS

0 replies

laysauchoa · 2024-02-23T10:18:36Z

laysauchoa
Feb 23, 2024
Author

Thank you! @jackton1 I gathered all the information here and what I am trying to achieve:

name: Folder Changes

on:
  pull_request:
    branches:
      - main

jobs:
  changed_files:
    runs-on: ubuntu-latest # windows-latest || macos-latest
    outputs:
      added_files: ${{ steps.set_file_changes.outputs.added_files }}
      deleted_files: ${{ steps.set_file_changes.outputs.deleted_files }}
      all_changed_files: ${{ steps.set_file_changes.outputs.all_changed_files }}
    name: Test changed-files
    steps:
      - uses: actions/checkout@v4
        with:
          fetch-depth: 0 # OR "2" -> To retrieve the preceding commit.

      # -----------------------------------------------------------------------------------------------------------
      # Example 1
      # -----------------------------------------------------------------------------------------------------------
      - name: Get changed files
        id: changed-files
        uses: tj-actions/changed-files@v42
        with:
          output_renamed_files_as_deleted_and_added: true
          dir_names: true
          files: A/*/

      - name: List all changed files
        env:
          ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
        run: |
          for file in ${ALL_CHANGED_FILES}; do
            echo "$file was changed"
          done

      - name: Summary of Changes
        env:
          ADDED_FILES: ${{ steps.changed-files.outputs.added_files }}
          DELETED_FILES: ${{ steps.changed-files.outputs.deleted_files }}
          ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }}
        run: |
          IFS=' ' read -ra paths_added_files <<< "$ADDED_FILES"
          IFS=' ' read -ra paths_deleted_files <<< "$DELETED_FILES"
          IFS=' ' read -ra paths_all_changed_files <<< "$ALL_CHANGED_FILES"

          echo "--------------------------------------------------------------------"
          echo "                    Summary of Changes                   "
          echo "--------------------------------------------------------------------"
          echo "created:"
          for file in "${paths_added_files[@]}"; do
            echo "- ${file}"
          done

          echo "                        "
          echo "deleted:"
          for file in "${paths_deleted_files[@]}"; do
            echo "- ${file}"
          done
          echo "                        "

          echo "updated:"
          for file in "${paths_all_changed_files[@]}"; do
            echo "- ${file}"
          done

Logs:

##[debug]Evaluating: steps.changed-files.outputs.all_changed_files
##[debug]Evaluating Index:
##[debug]..Evaluating Index:
##[debug]....Evaluating Index:
##[debug]......Evaluating steps:
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'changed-files'
##[debug]....=> Object
##[debug]....Evaluating String:
##[debug]....=> 'outputs'
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'all_changed_files'
##[debug]=> 'A/B-new/C/D A/B[2](https://github.com/laysauchoa/repo-from-template/actions/runs/8017595949/job/21902073619#step:4:2)/C2-new/D2'
##[debug]Result: 'A/B-new/C/D A/B2/C2-new/D2'
##[debug]Evaluating condition for step: 'List all changed files'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: List all changed files
##[debug]Loading inputs
##[debug]Loading env
Run for file in ${ALL_CHANGED_FILES}; do
##[debug]/usr/bin/bash -e /home/runner/work/_temp/faee5f21-11d1-4c25-9596-44c0f2e6c83c.sh
A/B-new/C/D was changed
A/B2/C2-new/D2 was changed
##[debug]Finishing: List all changed files
0s
##[debug]Evaluating: steps.changed-files.outputs.added_files
##[debug]Evaluating Index:
##[debug]..Evaluating Index:
##[debug]....Evaluating Index:
##[debug]......Evaluating steps:
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'changed-files'
##[debug]....=> Object
##[debug]....Evaluating String:
##[debug]....=> 'outputs'
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'added_files'
##[debug]=> 'A/B-new/C/D A/B2/C2-new/D2'
##[debug]Result: 'A/B-new/C/D A/B2/C2-new/D2'
##[debug]Evaluating: steps.changed-files.outputs.deleted_files
##[debug]Evaluating Index:
##[debug]..Evaluating Index:
##[debug]....Evaluating Index:
##[debug]......Evaluating steps:
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'changed-files'
##[debug]....=> Object
##[debug]....Evaluating String:
##[debug]....=> 'outputs'
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'deleted_files'
##[debug]=> 'A/B/C/D A/B2/C2/D2'
##[debug]Result: 'A/B/C/D A/B2/C2/D2'
##[debug]Evaluating: steps.changed-files.outputs.all_changed_files
##[debug]Evaluating Index:
##[debug]..Evaluating Index:
##[debug]....Evaluating Index:
##[debug]......Evaluating steps:
##[debug]......=> Object
##[debug]......Evaluating String:
##[debug]......=> 'changed-files'
##[debug]....=> Object
##[debug]....Evaluating String:
##[debug]....=> 'outputs'
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'all_changed_files'
##[debug]=> 'A/B-new/C/D A/B2/C2-new/D2'
##[debug]Result: 'A/B-new/C/D A/B2/C2-new/D2'
##[debug]Evaluating condition for step: 'Summary of Changes'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Summary of Changes
##[debug]Loading inputs
##[debug]Loading env
Run IFS=' ' read -ra paths_added_files <<< "$ADDED_FILES"
##[debug]/usr/bin/bash -e /home/runner/work/_temp/411ebc54-4c79-44[3](https://github.com/laysauchoa/repo-from-template/actions/runs/8017595949/job/21902073619#step:4:3)1-90fc-8083[6](https://github.com/laysauchoa/repo-from-template/actions/runs/8017595949/job/21902073619#step:4:6)29[7](https://github.com/laysauchoa/repo-from-template/actions/runs/8017595949/job/21902073619#step:4:7)62[21](https://github.com/laysauchoa/repo-from-template/actions/runs/8017595949/job/21902073619#step:4:21).sh
--------------------------------------------------------------------
                    Summary of Changes                   
--------------------------------------------------------------------
created:
- A/B-new/C/D
- A/B[2](https://github.com/laysauchoa/repo-from-template/actions/runs/8017595949/job/21902073619#step:5:2)/C2-new/D2
                        
deleted:
- A/B/C/D
- A/B2/C2/D2
                        
updated:
- A/B-new/C/D
- A/B2/C2-new/D2

Why is the global pattern matching with C2-new? I am trying to filter out changes to only a level like a folder level and not the whole inner pattern, so I am not sure how to achieve that. Other folder changes, should not be included this is what I thought.

1 reply

jackton1 Feb 23, 2024
Maintainer

I believe this is likely a misunderstanding of the action itself changes git tracks are to files not to directories. The pattern you specified A/*/ would match any changed file within the A directory.

If you intend to match only specific subfolders or files you’ll have to be explicit about the pattern you specify.

Match files in the images folder

Match files in the the images subfolder

Hope this clarifies things

laysauchoa · 2024-02-23T14:09:10Z

laysauchoa
Feb 23, 2024
Author

@jackton1 I appreciate your answer and I feel I am starting to understand. So the action will not track folder rename only, right? as it would give me a path to a file. Empty folders are not tracked by git but the path will always be resolved to a file even if just a directory was renamed without changes in inner directories.

2 replies

jackton1 Feb 23, 2024
Maintainer

A folder rename should be considered from the file level not the folder level. Renaming a file tracked by git is similar to changing the folder the file was in e.g A/b.txt renaming A to B simply means the location is now B/b.txt which gets tracked as a move if b.txt is not changed or a delete and create if the contents of b.txt has changed. The phrase “So the action will not track folder rename only” again is incorrect git tracks files not folders I.e content changes.

This action uses git to output the list of tracked changed files i.e b.txt you can optionally output only the directory name which is done by dir_names input. In the example above if it’s a directory rename A/b.txt -> B/b.txt the output would be renamed_files: B/b.txt …

Answer selected by jackton1

laysauchoa Feb 23, 2024
Author

Gotcha, thank you so much!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Matching directories with inner directories #1947

{{title}}

Replies: 3 comments 3 replies

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Matching directories with inner directories #1947

laysauchoa Feb 20, 2024

Replies: 3 comments · 3 replies

jackton1 Feb 20, 2024 Maintainer

Example

laysauchoa Feb 23, 2024 Author

jackton1 Feb 23, 2024 Maintainer

Match files in the images folder

Match files in the the images subfolder

laysauchoa Feb 23, 2024 Author

jackton1 Feb 23, 2024 Maintainer

laysauchoa Feb 23, 2024 Author

laysauchoa
Feb 20, 2024

Replies: 3 comments 3 replies

jackton1
Feb 20, 2024
Maintainer

laysauchoa
Feb 23, 2024
Author

jackton1 Feb 23, 2024
Maintainer

laysauchoa
Feb 23, 2024
Author

jackton1 Feb 23, 2024
Maintainer

laysauchoa Feb 23, 2024
Author