Respect negate property in attributeName #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: [email protected]
abetomo
approved these changes
Sep 15, 2024
shadowspawn
added
the
pending release
shadowspawn
removed
the
pending release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
attributeNamewas unconditionally stripping the leadingno-from the option name. The rest of the code respects thenegateproperty, allowing an author to override thenegateproperty and have an option namenoFoo.This is a trimmed down version of #2238, which had tests.
Solution
Use the
negateproperty inattributeName()which is consistent with rest of code testing for negation.Not adding tests as do not wish to commit to supporting overriding negation in this way. Adding this change as a reasonable thing to do locally.
Added @bernard-wagner as co-author on commit. If you are approve this PR @abetomo, I'll do the merge to try and make sure the co-author attribution gets preserved (bit fragile).