You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 18, 2023. It is now read-only.
Expected behavior
If there are only changes to the lock file but none to the package.json I guess we could ignore the PR since it's not really updating something, or is it?
I have finally found some time to look into this.
As to the case where there are only changes package-lock.json, there are cases where that is possible and desirable.
Given a dependency defined as folloes in package.json:
{
..."dependencies": {
"my-dep": "1.2"
}
...
}
This is one way of describing to npm that you want the latest available patch version. In those cases there are only updates in package-lock.json.
For dedup/prun case I think the npm update --package-lock-only command this action run reverts the effects of dedupe/prune commands.
I can create a new version where you have the possibility to have npm dedupe and/or npm prune after npm update --package-lock-only
Does this seem like a solution to you @Primajin ?
That does sounds cool - but please don't get into too much hassle on my account 😅 . I am also fine to just merge and run a dedupe/prune every now and then locally on my machine. No worries! 👍🏻
Describe the bug
Hey there the new action with NPM 7 works pretty great, though I just got a funky PR that only has package.lock changes. I wonder if in that case the update should be ignored. Also I had pruned and deduped my lock file so it seems there is a lot of unnecessary new lines added: https://github.com/Primajin/eyesbound/pull/61/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519R22982
To Reproduce
Steps to reproduce the behavior:
npm i
npm dedupe
andnpm prune
to make it smallerExpected behavior
If there are only changes to the lock file but none to the package.json I guess we could ignore the PR since it's not really updating something, or is it?
Link to workflows
https://github.com/Primajin/eyesbound/runs/3553773888?check_suite_focus=true
The text was updated successfully, but these errors were encountered: