Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments are bound to location of code instead of code itself. #2

Open
Dinesh-AR opened this issue Mar 25, 2019 · 9 comments
Open

comments are bound to location of code instead of code itself. #2

Dinesh-AR opened this issue Mar 25, 2019 · 9 comments

Comments

@Dinesh-AR
Copy link

For example, when I add comment to line 10 and later if add couple of line before line 10. The comment is applied to newly added code which is present in location line 10.

@tkrkt
Copy link
Owner

tkrkt commented Mar 25, 2019

Thank you for your comment. As you say, it is good to add an option to shift the position of notes on editing. This is a simple extension, so it may not have enough features...
[Edit]: Obviously it would be useful to have it. This feature should be added.

@FatehAK
Copy link

FatehAK commented May 8, 2019

I second this feature. This would definitely be handy. This is implemented in this extension, you could check it out

@HoldYourWaffle
Copy link

This is definitely a good feature to have, it's annoying to lose (as in can't find them) your notes because you're moving code around.

@PeterBenc
Copy link

PeterBenc commented Sep 6, 2019

Please add this feature, without it the whole extension doesnt make sense. In which state of progress is the work on this?

@andywhitaker
Copy link

I also would like to say this is a feature I'd love to see added. In addition I want to say THANK YOU!! for this extension! I was wanting the ability to have inline notes as a feature in VS Code and then decided to search to see if someone else had done it and sure enough your extension already existed with great features! If you have time and develop this further the ability to have the notes move with the original line they are applied to would be nice as well as the notes updating their references if a file is renamed. Currently when renaming a file the notes disappear and if a new file is created with the original file's name the notes become associated with that new file.

With that said, even if these features aren't added I just want to say thanks again the plugin as it has been nice to use.

Thanks!

@ohansemmanuel
Copy link

Thanks for the plugin! This is a feature most people would like. If you're happy to support this, I could look into it and issue a PR - a working draft we can refine. Let me know 😊

@tkrkt
Copy link
Owner

tkrkt commented Feb 21, 2020

PR is very helpful! 😄

@prmichaelsen
Copy link

For example, when I add comment to line 10 and later if add couple of line before line 10. The comment is applied to newly added code which is present in location line 10.

Note sure if you're still interested in the use case, but I implemented that functionality here: https://marketplace.visualstudio.com/items?itemName=prmichaelsen.linenoteplus

@dokmanc
Copy link

dokmanc commented Sep 29, 2023

I don't think adding functionality to auto shift notes when a user edits the file is practical, especially in a multi-user environment where multiple users are modifying both the code and the notes and then checking code into GIT. The merging would be a nightmare. @prmichaelsen has the right design approach with his fork extension "Line Note Plus" but the project is too buggy and I really think it needs an option to be able to hide all of the comment links that his approach requires to reduce the visual noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants