Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'removeNoteWithConfirmation' command and associate with 'remove' UI #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add 'removeNoteWithConfirmation' command and associate with 'remove' UI #12

wants to merge 1 commit into from

Conversation

canadaduane
Copy link

Fixes #8

canadaduane
canadaduane commented Oct 15, 2020
View reviewed changes
src/extension.ts
decorateDebounce();
}
const confirmed = await vscode.window
.showInformationMessage(`Are you sure you'd like to permanently remove this note?`,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not as familiar with translation files... maybe add a translation for this? How?

src/extension.ts
}
const confirmed = await vscode.window
.showInformationMessage(`Are you sure you'd like to permanently remove this note?`,
...['Yes', 'No']) === 'Yes';
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for Yes/No, probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirm on delete
1 participant
@canadaduane