Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using defaults for Action & Context enums #5

Open
lsloan opened this issue Sep 13, 2023 · 0 comments
Open

using defaults for Action & Context enums #5

lsloan opened this issue Sep 13, 2023 · 0 comments
Assignees
@lsloan
Labels
bug Something isn't working

Comments

@lsloan
Copy link
Member

lsloan commented Sep 13, 2023

  1. (bug) The Action enum has an invalid __default value, the empty string (''). If it must have a default value, it should be null. Even better, the enum shouldn't have a default value at all, which will cause an error if one is not specified.
  2. (enhancement) The Context enum should have its __default value set to self::CONTEXT. That would allow code to be a little briefer.
@lsloan lsloan added the bug Something isn't working label Sep 13, 2023
@lsloan lsloan self-assigned this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsloan lsloan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lsloan