Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

singleton third dimension with mmap=true #61

Open
bjarthur opened this issue Aug 18, 2021 · 2 comments
Open

singleton third dimension with mmap=true #61

bjarthur opened this issue Aug 18, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@bjarthur
Copy link

bjarthur commented Aug 18, 2021

julia> img = TiffImages.load("myimage.tif");

julia> size(img)
(10512, 6336)

julia> img = TiffImages.load("myimage.tif", mmap=true);

julia> size(img)
(10512, 6336, 1)

julia> img = ImageMagick.load("myimage.tif");

julia> size(img)
(10512, 6336)
@tlnagy tlnagy added the bug Something isn't working label Aug 18, 2021
@tlnagy
Copy link
Owner

tlnagy commented Aug 18, 2021

Good catch, mmap should be consistent with normal loading on this.

@tlnagy
Copy link
Owner

tlnagy commented Aug 18, 2021

It appears that I built the mmap type with the assumption that folks will only use it for 3D images because it doesn't make too much sense otherwise, since the primary benefit is loading the image 2D slice by 2D slice.

I guess I could parameterize the type on the number of dimensions and then have a trivial mmap type for the 2D case.

@tlnagy tlnagy added enhancement New feature or request and removed bug Something isn't working labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants