Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another punctuation issue #109

Open
matchachoco95 opened this issue Jan 23, 2023 · 5 comments
Open

Another punctuation issue #109

matchachoco95 opened this issue Jan 23, 2023 · 5 comments
Assignees

Comments

@matchachoco95
Copy link

matchachoco95 commented Jan 23, 2023

Describe the bug
When classifying a previously unpunctuated line as "Heading (same level)", it sometimes (but not always) happens that the line is converted to a bigger size (as it should) but that it starts showing as unpunctuated with no way to edit it again after, i.e. the line cannot be annotated or edited at that point, neither via the lock right next to it (left) nor via the lock that appears when you highlight a portion of the line (right). It ends up looking like this:

23 01 2023

Marked in red is the line that can no longer be edited; the buttons marked in orange no longer work (clicking on them yields no result whatsoever). Editing via the "Edit Chinese text" option is possible but that will not make the lock next to it disappear, hence rendering it impossible to add a translation to the line.

It's a very specific issue and can probably avoided by first converting to Root Text and then editing it to be a headline later on but I thought I would bring it up anyway when it happened for the second time. Curiously, I believe that once or twice when I performed the same steps the whole thing worked just fine, so it is a bit odd.

To Reproduce
Steps to reproduce the behavior:

  1. Go to an unpunctuated text.
  2. Click on the lock next to one of the lines that are supposed to be chapter headings.
  3. Attempt to convert it into a headline by clicking on the lock next to it ("Add punctuation to this segment").
  4. Do not change anything else about the line - merely select "Heading (same level)" in the "type of text" section. Click on either "Save but don't split" or "Save text and continue". (Come to think of it, I did not pay attention to which of those I clicked each time - might be related to this?)
  5. See error (or don't - so far it has been a coinflip for me).

Expected behavior
I would like the line to show up like the others around it: ready to have a translation or attributions added to it. Alternatively, it would be nice to be able to edit the line again to potentially fix the issue.

Desktop (please complete the following information):

  • OS: Windows 10 Pro
  • Browser: Google Chrome
  • Version: 109.0.5414.75 [64-bit]

EDIT: After saving a line as Root Text and then attempting to convert it into a heading, the TLS displayed an error message. After refreshing the page, however, it had worked.

@cwittern
Copy link
Contributor

Thank you for this report and for the detailed explanation. This should be sufficient to trace down the problem.

As for the expected behavior, I think that changing the line to a heading should remove the lock, without the need for further action, such as adding punctuation. Punctuation is rarely needed for headings after all.

In addition, while looking at this text it seemed to me that the text has some structural problems as well. Maybe the conversion has to be redone. Did you spend much time working on this text already?

@cwittern cwittern self-assigned this Jan 25, 2023
@matchachoco95
Copy link
Author

Thank you for your reply! I'm glad my description was helpful.

As for your question: @baianja told me that she wanted to talk to you about this exact issue as there seem to be some oddities throughout the entire thing. I have in fact worked on the text for a bit already but I would not be opposed to that work being erased if the text were to become more easily accessible after, so there is no need to be concerned. :)

@matchachoco95
Copy link
Author

Small update (posting on here because it's about the same text that was already suspected to be a bit compromised): After trying to merge two lines together where the first part of the line unfortunately happened to be the first on the page (which always leads to the error "first segment" but which is usually solved after refreshing the page), the TLS outright refused to let me access the page in question again, even after refreshing multiple times.
When I went back to the front page and reentered the text, I managed to access the page but there was a problem: the merged line is now there about ten times (i. e. the program inserted the line into the text multiple times), still split, along with the previous two lines (see screenshot for clarification). When I started deleting the superfluous lines manually, the program once somehow deleted not just the line that I clicked the X on but one a few lines prior as well? It's a strange mistake, and one that I have not encountered before, so I do not know how easily reproducable it is; however, I hope I could at least make it clear by means of my description.

TLS Fehler 23 03

@matchachoco95
Copy link
Author

Also in the same text (sorry, I know this is a lot): I mistakenly put the type of a line as "new paragraph" instead of "heading" (I misclicked), and now apparently it cannot be changed back. Not a huge issue obviously but one to look out for potentially.

@cwittern
Copy link
Contributor

I tried to work on the problem, but could not find it in the text now. Moreover, I tried to solve the problem with multiple identical lines yesterday, so please tell me if the problem still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants