Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose upstream integration. #11

Open
tmc opened this issue Dec 14, 2017 · 6 comments
Open

Propose upstream integration. #11

tmc opened this issue Dec 14, 2017 · 6 comments

Comments

@tmc
Copy link
Owner

tmc commented Dec 14, 2017

I'd like to get this merged into the gateway as it's very closely related to it.

@TvdBrink
Copy link

Any update on this?

@tmc
Copy link
Owner Author

tmc commented Mar 20, 2020

@TvdBrink I'm sure we could get it in -- I think some test coverage would be in order. Do you think you could assist with that?.

@TvdBrink
Copy link

TvdBrink commented Mar 20, 2020

@tmc yes of course. Any preference on using third party packages in tests?

Also, is there any chance we could incorporate the ping and pong handlers of gorilla web socket as in the chat example?

@tmc
Copy link
Owner Author

tmc commented Mar 20, 2020

That sounds like a good example to express. My preference is to just use stdlib for testing (but maybe go-cmp for the comparison helper).

@TvdBrink
Copy link

Alright, I will make two PR's soon.

@tamama
Copy link

tamama commented Nov 26, 2023

@tmc @TvdBrink

Hi, it seems that upstream integration is a no-win situation as of now?

May I ask why grpc_gateway is unwilling to merge this?

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants