-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import message crash at the end #142
Comments
Are you saying that no images are imported? We need to narrow down the problem - let's try to get a minimal reproducible example. Try to do an export of only one MMS message - does importing such an export still crash? Does it matter which MMS message is in the file (you can try exporting a couple of messages and removing one by hand)? Edit: Please include logcats from a debug build, and please include more of the logcat - I suspect that there may be an error shown earlier in the logcat. |
I have the same issue. I can export 99k SMS messages and it only takes up 4mb, does that sound right? But when I try to export 17k mms messages it goes through the whole count, then closes. So I tried exporting 200 mms and got app closed unexpectedly message. Then tried 150 and it worked. |
Yes - SMS messages, including all their metadata, do not take up that much space, and being text, they compress quite well (via the ZIP compression).
The OP reported a problem with importing - is your problem with importing or exporting?
As per my message above, please post a full logcat from a debug build using a minimal reproducible example message file. |
Yes exactly, in the SMS app I see the text but no image I tried to import an export of only 3 SMS and 3 MMS and it crashed, here is the complete logcat :
I also tried to edit the export to leave only 1 SMS and 1 MMS. I did it twice, leaving a different MMS each time, and both crashed for the MMS (the SMS imported correctly) The 2 minimal NDJSON files are attached : messages.zip I haven't try with a debug build yet, I will do it soon. |
Hello, sorry for the late reply, here is the logcat from the last debug build : https://github.com/tmo1/sms-ie/actions/runs/7167672843
|
Thank you. I have reproduced the problem using your NDJSON and a random image file. I have a potential idea or two I'm going to look into. |
Some MMS part metadata apparently contain a sub_id field (despite the absence of any mention of this in the API documentation at https://developer.android.com/reference/android/provider/Telephony.Mms.Part), and attempting to import these sub_ids can cause the app to crash with a FileNotFoundException: No entry for content. This is probably related to #128. In any event, this commit fixes the problem by extending the solution to that issue (c56fa0e) to MMS part metadata sub_ids. Addresses: #142 Related: #128
Hello, The problem is the presence of the |
Hello thank you, I tried with the last debug build and the app doesn't crash anymore, I see the last screen telling me that the import went well but the images are still not imported and I see this error in the log :
|
I'm not sure what's going on here. The exception here seems to be caused by the SMS, not the MMS. Please make sure that you have granted the app READ_SMS permission, and please post the logs from import runs of just SMS and just MMS. |
Yes that's strange, I checked and the app does have the permission SMS=allow This is the log for a file with 1 MMS with 1 jpeg.
|
Okay, I'm going to have to see whether I can reproduce the problem. Please post a minimal Zip file that demonstrates the problem - start with one of the actual files that you used, extract |
Here is the minimal zip I used : |
Thank you. I imported your Zipfile, and the image imported correctly (it appears along with the message in the standard message app). Since I cannot reproduce your problem, and there's nothing unusual in the logs (yours or mine), I'm not sure what else I can do. |
Hello, so probably something wrong with my phone then, maybe a permission problem ? I will give it another try. |
I really don't know. It's certainly possible that there's a bug in the app - Android message handling and storage is complex and opaque, and there may be corner cases where things don't work. I'm sorry I can't help further at this point.
According to the exports I've seen, they're stored in |
Some MMS address metadata apparently contain a sub_id field (despite the absence of any mention of this in the API documentation at https://developer.android.com/reference/android/provider/Telephony.Mms.Addr), and attempting to import these sub_ids can cause address import failure. This is probably related to #128. In any event, this commit fixes the problem by extending the solution to that issue (c56fa0e) to MMS address metadata sub_ids. This commit also corrects a coding error that caused MMS addresses to be inserted multiple times. Closes: #213 Related: #128, #142
Hello, I'm experiencing a crash when importing messages, it happens at the end of MMS importing.
In
messages-2023-12-05.zip
there ismessages.ndjson
and a folderdata
with all the images.After the crash I can see all the messages in my SMS app but no image.
System : GrapheneOS
SMS App : QKSMS
During import I see a lot of lines like this :
And when it crashes at the end :
Let me know if you need more log.
Thanks!
The text was updated successfully, but these errors were encountered: