Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import not complete, some messages missing depending on phone number format #205

Closed
dnfoo opened this issue Aug 24, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@dnfoo
Copy link

dnfoo commented Aug 24, 2024

As hinted here I can confirm that messages containing spaces in the "address" field are not imported by the current version 2.4.0.
For me this was quite a big issue, as lots of messages had their addresses formatted like "0123 4567890".

I'm submitting it as a separate issue so people can find it easier via the search function.

Here's the workaround that worked for me:

  • Extract messages.ndjson for the .zip file created by the backup function
  • Search and replace with a matching regex. I used search for ([0-9]{3,6}) ([0-9]{6,10}) and replace by \1\2 in xed.
  • Save the file and zip it again together with the "data" folder from the original zip.
  • Import this newly created zip file

Would love to see this fixed in an upcoming version.

@dnfoo dnfoo changed the title Import not complete, some messages missing depending on phnone number format Import not complete, some messages missing depending on phone number format Aug 24, 2024
@tmo1 tmo1 added the bug Something isn't working label Aug 30, 2024
@tmo1 tmo1 self-assigned this Aug 30, 2024
@tmo1
Copy link
Owner

tmo1 commented Aug 30, 2024

The main discussion of this problem is in issue #159, beginning here. I hope to push a fix within a couple of days.

@tmo1 tmo1 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
tmo1 added a commit that referenced this issue Sep 3, 2024
Don't skip messages whose addresses contain spaces upon insertion.

Commit 2f07074 (don't insert SMS messages whose addresses contain
spaces, since they're assumed to be group SMS messages which we don't
know how to handle correctly) introduced a regression of single
recipient SMS messages whose addresses contain spaces being skipped upon
insertion. Revert this change.

Addresses: #159, #205, #128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants