You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Animl code is predominantly written in Node and JS, and really the only reason we're using Python at all in the ingestion step is b/c getting exiftool to run in a Node Lambda runtime proved difficult (sadly this very promising node wrapper for it exiftool-vendored doesn't work in Lambda environments - go to the closed issues section of its repo and search for "Lambda" to learn why). So generally speaking, we are in agreement that we should continue to stick to Node by default and use it whenever possible.
Nick did his best to isolate the Python and Node code (option 3, above) but quirks of the Serverless Framework, however, are preventing us from completely separating the Python (ingest-image) and Node (ingest-zip) code bases into isolated directories because Serverless requires that the requirements.txt file exists at the root level. Moving away from Serverless is a goal (#26), so we're happy to scrap that and shift over to CloudFormation templates regardless but that would also allow us to better separate the Python and Node parts of the code. @postfalk is exploring that now and evaluating whether we can simply cleave off the EXIF data extraction into it's own self-contained service written in Python.
For the time-being, however, we're going to stick with this multi-language mono-repo approach, so closing this out for now.
The presence of Python and Node in the same repo makes the creation of two test suites somewhat challenging. There are several possible solutions.
The text was updated successfully, but these errors were encountered: