Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_spacings to allow xarray input #407

Closed
4 tasks done
w-k-jones opened this issue Feb 9, 2024 · 3 comments
Closed
4 tasks done

Update get_spacings to allow xarray input #407

w-k-jones opened this issue Feb 9, 2024 · 3 comments
Labels
bug Code that is failing or producing the wrong result

Comments

@w-k-jones
Copy link
Member

Get spacings function currently only allows iris cube input, we should add the dataarray -> cube decorator to allow xarray input

def get_spacings(field_in, grid_spacing=None, time_spacing=None):

  • Have you searched the issue tracker for the same problem?
  • Have you checked if you're using the latest version? If not, which version are you using?
  • Have you mentioned the steps to reproduce the issue?
  • Have you, if applicable, included error messages?
@w-k-jones w-k-jones added the bug Code that is failing or producing the wrong result label Feb 9, 2024
@w-k-jones
Copy link
Member Author

It will be best to wait until both #380 and #400 have been merged to do this to avoid conflicts

@fsenf
Copy link
Member

fsenf commented Feb 28, 2024

We have this functionality already in #334 waiting for approval by @w-k-jones and @fziegner . I am going to close to issue - hope that is fine for you.

@fsenf fsenf closed this as completed Feb 28, 2024
@w-k-jones
Copy link
Member Author

We have this functionality already in #334 waiting for approval by @w-k-jones and @fziegner . I am going to close to issue - hope that is fine for you.

We will have to update it to use the new method for calling decorators in #380 though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Development

No branches or pull requests

2 participants