Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license warning can hardly be seen by the developer #81

Open
derStephan opened this issue Jul 31, 2024 · 3 comments
Open

license warning can hardly be seen by the developer #81

derStephan opened this issue Jul 31, 2024 · 3 comments

Comments

@derStephan
Copy link

derStephan commented Jul 31, 2024

I just moved our new kirby site from a test domain to the actual domain. From this moment on, dream form was no longer licensed for me. Unfortunately, I did not know that the license is bound to the URL and did not check the back end.

After the change of the URL, I tested all forms for correct behaviour. There was no problem. Now I get angry calls from real users complaining that they need to login to submit forms. They see this error message:

grafik

It says that dream form is in demo mode and will only accept submissions from logged in users.

I absolutely understand that there are restrictions in place. But hiding this relevant information from logged in users whilst showing that to actual users is the worst of all possible ways to inform the developer.

May I ask you to show this error BEFORE filling stuff in and regardless of logged in state? Otherwise other developers may run into the same problem when deploying kirby and dream form to production.

@tobimori
Copy link
Owner

tobimori commented Aug 1, 2024

Unfortunately, there are a few downsides:

  • Showing it regardless of logged in state would make it impossible to test the plugin without a license, which is exactly what my intention is (in this case, the licensing works the same way as Kirby's own: you shall only need a license once you go live)
  • Showing it all the time for not logged in users would require a kirby()->user() call which makes the form page uncachable.
  • Showing it all the time for all users would remove the possibility to style the form locally without the error visible.

@derStephan
Copy link
Author

derStephan commented Aug 1, 2024

Showing it all the time for all users would remove the possibility to style the form locally without the error visible

You could give this message another class to make it unique. So if I absolutely must, I can hide it by CSS without interfering with the other errors. But at least I can not simply miss it.

@tobimori
Copy link
Owner

Coming back to this, is there anything wrong about the notice in the panel, which explicitly has the same text? Should I make it red so it's more obvious?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants