fix(edgeless): memory leak in edgeless widgets (#8862)

toeverything · Dec 5, 2024 · 4f02d3a · 4f02d3a
1 parent ff41d91
commit 4f02d3a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/packages/blocks/src/root-block/edgeless/components/toolbar/present/frame-order-menu.ts b/packages/blocks/src/root-block/edgeless/components/toolbar/present/frame-order-menu.ts
@@ -184,6 +184,11 @@ export class EdgelessFrameOrderMenu extends WithDisposable(LitElement) {
     });
   }
 
+  override disconnectedCallback(): void {
+    super.disconnectedCallback();
+    this._disposables.dispose();
+  }
+
   override firstUpdated() {
     this._bindEvent();
   }

diff --git a/...ges/blocks/src/root-block/edgeless/components/toolbar/present/navigator-setting-button.ts b/...ges/blocks/src/root-block/edgeless/components/toolbar/present/navigator-setting-button.ts
@@ -92,6 +92,11 @@ export class EdgelessNavigatorSettingButton extends WithDisposable(LitElement) {
     this._tryRestoreSettings();
   }
 
+  override disconnectedCallback(): void {
+    this._navigatorSettingPopper?.dispose();
+    this._navigatorSettingPopper = null;
+  }
+
   override firstUpdated() {
     this._navigatorSettingPopper = createButtonPopper(
       this._navigatorSettingButton,