From 7c2753516348fef8b725cab73a960d373775ea1d Mon Sep 17 00:00:00 2001
From: punker <gleb@together.ai>
Date: Fri, 31 Jan 2025 17:35:58 +0000
Subject: [PATCH] rollback partially

---
 api/v1/helper.go                          | 6 ++----
 controllers/generic_network_controller.go | 3 ---
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/api/v1/helper.go b/api/v1/helper.go
index 823fa25fd..62ea0d2a5 100644
--- a/api/v1/helper.go
+++ b/api/v1/helper.go
@@ -40,8 +40,6 @@ const (
 	SriovCniStateOn      = "on"
 	SriovCniIpam         = "\"ipam\""
 	SriovCniIpamEmpty    = SriovCniIpam + ":{}"
-
-	CniType = "ib-sriov"
 )
 
 const invalidVfIndex = -1
@@ -52,6 +50,7 @@ var log = logf.Log.WithName("sriovnetwork")
 // NicIDMap contains supported mapping of IDs with each in the format of:
 // Vendor ID, Physical Function Device ID, Virtual Function Device ID
 var NicIDMap = []string{}
+
 var InitialState SriovNetworkNodeState
 
 // NetFilterType Represents the NetFilter tags to be used
@@ -696,7 +695,7 @@ func (cr *SriovIBNetwork) RenderNetAttDef() (*uns.Unstructured, error) {
 
 	// render RawCNIConfig manifests
 	data := render.MakeRenderData()
-	data.Data["CniType"] = CniType
+	data.Data["CniType"] = "ib-sriov"
 	data.Data["SriovNetworkName"] = cr.Name
 	if cr.Spec.NetworkNamespace == "" {
 		data.Data["SriovNetworkNamespace"] = cr.Namespace
@@ -764,7 +763,6 @@ func (cr *SriovNetwork) RenderNetAttDef() (*uns.Unstructured, error) {
 
 	// render RawCNIConfig manifests
 	data := render.MakeRenderData()
-
 	data.Data["CniType"] = "sriov"
 	data.Data["SriovNetworkName"] = cr.Name
 	if cr.Spec.NetworkNamespace == "" {
diff --git a/controllers/generic_network_controller.go b/controllers/generic_network_controller.go
index 784a01124..e6b84d3aa 100644
--- a/controllers/generic_network_controller.go
+++ b/controllers/generic_network_controller.go
@@ -124,11 +124,8 @@ func (r *genericNetworkReconciler) Reconcile(ctx context.Context, req ctrl.Reque
 		}
 		return reconcile.Result{}, err
 	}
-
 	raw, err := instance.RenderNetAttDef()
-
 	if err != nil {
-		reqLogger.Error(err, "Failed to render NetworkAttachmentDefinition")
 		return reconcile.Result{}, err
 	}
 	netAttDef := &netattdefv1.NetworkAttachmentDefinition{}