Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When switching Themes, switch the Figma native theme mode selector if possible #2187

Open
Tracked by #2106
esthercheran opened this issue Aug 23, 2023 · 1 comment · May be fixed by #2336
Open
Tracked by #2106

When switching Themes, switch the Figma native theme mode selector if possible #2187

esthercheran opened this issue Aug 23, 2023 · 1 comment · May be fixed by #2336
Assignees
@robinhoodie0823
Labels
2.0-followup ❇️ Featurebase Roadmap Issue was added to a featurebase roadmap post Figma variables 💡request Community feedback themes pro feature for theme groups and themes variables-m2

Comments

@esthercheran
Copy link
Collaborator

esthercheran commented Aug 23, 2023 •
edited
Loading

On switching Themes inside the plugin itself, right now nothing happens if users are using Variables. We should change that so we change the native theme switcher when we switch using the plugin.

We need to differentiate between Apply modes here:

  • Page: Only switch the mode selector of the current page
  • Document: Switch only the mode selector of all pages
  • Selection: Only switch the actively selected items mode selectors, not the children

For example, if I have 5 frames selected (that each have children), Selection would change the mode selector of these 5 frames, not the mode selectors of their children.

CleanShot.2023-10-16.at.15.50.33-converted.mp4
@esthercheran esthercheran mentioned this issue Aug 23, 2023
Closed
@six7 six7 moved this from 📥 Triage to 📤 Ready for dev in Tokens Studio for Figma Roadmap Sep 4, 2023
@six7 six7 added variables-m2 design Design is needed labels Sep 13, 2023
@LukeFinch LukeFinch removed the design Design is needed label Sep 29, 2023
@robinhoodie0823 robinhoodie0823 moved this from 📤 Ready for dev to 🕜 In Progress in Tokens Studio for Figma Roadmap Oct 16, 2023
@robinhoodie0823 robinhoodie0823 self-assigned this Oct 16, 2023
@robinhoodie0823 robinhoodie0823 moved this from 🕜 In Progress to 👀 Needs review in Tokens Studio for Figma Roadmap Oct 26, 2023
@SorsOps SorsOps linked a pull request Nov 6, 2023 that will close this issue
Open
@esthercheran esthercheran moved this from 👀 Needs review to 📋 Changes requested in Tokens Studio for Figma Roadmap Nov 7, 2023
@esthercheran esthercheran mentioned this issue Feb 5, 2024
Closed
@SamIam4Hyma SamIam4Hyma added Figma variables themes pro feature for theme groups and themes labels Mar 26, 2024
@SamIam4Hyma SamIam4Hyma added 💡request Community feedback ❇️ Featurebase Roadmap Issue was added to a featurebase roadmap post labels Apr 10, 2024
@SamIam4Hyma
Copy link
Collaborator

Added to Featurebase Roadmap- 💚 Theme management enhancements - QOL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinhoodie0823 robinhoodie0823

Labels
2.0-followup ❇️ Featurebase Roadmap Issue was added to a featurebase roadmap post Figma variables 💡request Community feedback themes pro feature for theme groups and themes variables-m2
Projects
Tokens Studio for Figma Roadmap
Status: 📋 Changes requested
Milestone
No milestone
6 participants
@six7 @LukeFinch @esthercheran @keeganedwin @robinhoodie0823 @SamIam4Hyma