Sync-Up With graph-gophers/graphql-go(Fork's) Master #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e has an error Signed-off-by: Kirill Danshin <[email protected]>
Prior to the fix, the new TestNilInterface test would fail with: graphql: panic occurred: reflect: Method on nil interface value
…l-panic panic message should me meaningful: invalid type should say which typ…
Fixed typos throughout project
reverse order of errors vs data in response
Properly handle nil interface resolvers
This benchmark was used to justify a tiny change in graph-gophers#218. Now that we all know the joys of fmt.Stringer, I don't see any reason to keep this file around, especially in the root package.
Validate types are including all fields from implemented interface(s)
Use Struct Field Resolver instead of Method
…-go-module convert to go module
Implement error propagation on non-null fields
Allows the server to disable schema introspection.
Add DisableIntrospection SchemaOpt
Moving package globals to per-schema objects, resolving data races from parsing multiple schemas in parallel. While this has limited likelihood in production code (since typically just 1 schema would be used), tests are a different story
Validating enum values supplied via variable input, and those returned from resolvers, ensuring that only valid enum values defined by the GraphQL schema are accepted
…on-schema-parsing Resolve schema parsing data races
…ation Fix Enum validation
Introspection via ToJSON works differently when used via the `Schema.ToJSON` function than when making an introspection query from a client such as GraphiQL. In the later case, introspection uses the Schema's registered resolver, while in the former case, a `resolvable.Schema` is faked Without the `Meta` being set on this `resolvable.Schema` (following the recent changes to address race conditions around the Meta schema), this resulted in a panic when using this form of schema introspection.
…ntrospection-tojson Fix Panic on Introspection of Schema using ToJSON
Fix parsing of descriptions
Validating Input values supplied via variable input are supplied with the correct input structure and values. This includes ensuring that enum embedded within input values are validated as well
…dation Fix Input Value Validation
update opentracing-go version
Adding example app that allows responses to be cached based on hints added to the request context by resolvers. HTTP Cache-Control header is added using a customised version of the `relay` package HTTP handler implementation
Query Caching Example
abhif22
changed the title
as far as I can see, this is your only commit, CMIIW as I only checked this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last Sync-Up occurred on Aug 6, 2018. This PR is for syncing up with latest(Jul 25, 2019).
Changes
d69a0b9#diff-47a7942f5c3771dc4c337e572574277eL32
Note: We are trying to merge this PR into
fix-respsince we are usingfix-respbranch as dependency for gqlserver (https://github.com/tokopedia/graphql-go/releases/tag/v1.2)