Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto uploads and multi projects proto #54

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

quintans
Copy link

This is a massive change. I just went crazy 😄
I understand if this gets rejected. Feel free to cherry pick any change.

changes:

  • go modules
  • Uploading proto files
  • Immediate sub directories can represent different imports
  • Packages at the same Level - proto files defined at their own folders and none of them is at the min package (top level)
  • generating *.pg.go into GOPATH

@jekiapp
Copy link
Contributor

jekiapp commented Sep 15, 2020

haha thankyou for creating this PR, it must be a lot of hardwork. But first, instead of focusing on the chages I am more interested about the motivation for each changes. Like uploading the proto is interesting, but what challenge you face until you made that feature?

Actually one of the issue gripmock has is generated code is placed in the top level. I forgot which issue it is but it's there.

@pcriv
Copy link

pcriv commented Apr 23, 2021

The multi-project support from this MR would actually come super useful. @jekiapp any change an MR with just that change would be accepted?

@cezarypiatekGC
Copy link

Hi @jekiapp, can you merge the feature allowing for proto upload?

@imcom
Copy link

imcom commented Jun 5, 2022

kudos to @quintans ! I see some pretty useful changes in the PR, but this PR is definitely too huge to merge ... cherry picking from this work is also non-trivial, from current commits ... Probably need to separate the several features into PRs respectively in order to get things moving @jekiapp WDYT

@jekiapp
Copy link
Contributor

jekiapp commented Jun 6, 2022

Hi guys, sorry for the late replies.
This PR is already too old and got a lot of conflicts, it would be impossible for me to merge this. But some of the features are worth to be considered and proposed in a dedicated issue like multi-project and upload protos.
For now, if you guys really need what @quintans have been done, you can use his forks instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants