Skip to content

Commit

Permalink
[ksqlDB.RestApi.Client]: fixed ManagePackageVersionsCentrally in Dire…
Browse files Browse the repository at this point in the history
…ctory.Build.props issue with dotnet SDK 8.0.300
  • Loading branch information
tomasfabian committed May 24, 2024
1 parent 4149ea8 commit 93c8f33
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Setup .NET 8.0
uses: actions/setup-dotnet@v4
with:
dotnet-version: 8.0.205
dotnet-version: 8.0.x

- name: Clean
run: dotnet clean ksqlDb.RestApi.Client.sln --configuration Release && dotnet nuget locals all --clear
Expand Down
1 change: 0 additions & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@
<LangVersion>12.0</LangVersion>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<ManagePackageVersionsCentrally>false</ManagePackageVersionsCentrally>
</PropertyGroup>
</Project>
3 changes: 3 additions & 0 deletions Directory.Packages.props → Tests/Directory.Packages.props
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
</PropertyGroup>

<ItemGroup Label="EF and configuration Nugets for SqlServer.Connector tests">
<PackageVersion Include="Microsoft.EntityFrameworkCore" Version="8.0.0" />
Expand Down
2 changes: 1 addition & 1 deletion ksqlDb.RestApi.Client.sln
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "SolutionItems", "SolutionIt
.editorconfig = .editorconfig
.gitignore = .gitignore
Directory.Build.props = Directory.Build.props
Directory.Packages.props = Directory.Packages.props
Tests\Directory.Packages.props = Tests\Directory.Packages.props
README.md = README.md
Vagrantfile = Vagrantfile
EndProjectSection
Expand Down

0 comments on commit 93c8f33

Please sign in to comment.