From eaa7993f2cda2754dbd00f8b6190c0a738eefbb8 Mon Sep 17 00:00:00 2001
From: Thomas Corbett <thomas.michael.corbett@gmail.com>
Date: Sun, 24 Mar 2024 17:14:20 +0000
Subject: [PATCH] Added unit test for case of GitHub API returning 204 empty
 content in ResultPager  #1091

---
 test/Github/Tests/ResultPagerTest.php | 63 +++++++++++++++++++++++++++
 1 file changed, 63 insertions(+)

diff --git a/test/Github/Tests/ResultPagerTest.php b/test/Github/Tests/ResultPagerTest.php
index 2839e16f3df..7c6d3afc1a5 100644
--- a/test/Github/Tests/ResultPagerTest.php
+++ b/test/Github/Tests/ResultPagerTest.php
@@ -6,6 +6,7 @@
 use Github\Api\Organization\Members;
 use Github\Api\Repository\Statuses;
 use Github\Api\Search;
+use Github\Api\Repo;
 use Github\Client;
 use Github\ResultPager;
 use Github\Tests\Mock\PaginatedResponse;
@@ -116,6 +117,40 @@ public function shouldGetAllSearchResults()
         $this->assertCount($amountLoops * count($content['items']), $result);
     }
 
+    /**
+     * @test 
+     */
+    public function shouldHandleEmptyContributorListWith204Header()
+    {
+        // Set up a 204 response with an empty body
+        $response = new Response(204, [], '');
+        $username = 'testuser';
+        $reponame = 'testrepo';
+
+        // Mock the HttpClient to return the empty response
+        $httpClientMock = $this->getMockBuilder(HttpClient::class)
+            ->onlyMethods(['sendRequest'])
+            ->getMock();
+        $httpClientMock
+            ->method('sendRequest')
+            ->willReturn($response);
+
+        $client = Client::createWithHttpClient($httpClientMock);
+
+        $repoApi = new Repo($client);
+
+        $paginator = $this->getMockBuilder(ResultPager::class)
+            ->setConstructorArgs([$client]) // Pass the Client in the constructor
+            ->onlyMethods(['fetchAll'])
+            ->getMock();
+        $paginator->expects($this->once())
+            ->method('fetchAll')
+            ->with($repoApi, 'contributors', [$username, $reponame])
+            ->willReturn([]);
+
+        $this->assertEquals([], $paginator->fetchAll($repoApi, 'contributors', [$username, $reponame]));
+    }
+
     public function testFetch()
     {
         $result = ['foo'];
@@ -201,6 +236,34 @@ public function testFetchAllWithoutKeys()
         $this->assertCount(9, $result);
     }
 
+    public function testFetchAll()
+    {
+        $content = [
+            ['title' => 'issue 1'],
+            ['title' => 'issue 2'],
+            ['title' => 'issue 3'],
+        ];
+
+        $response = new PaginatedResponse(3, $content);
+
+        // httpClient mock
+        $httpClientMock = $this->getMockBuilder(HttpClient::class)
+            ->onlyMethods(['sendRequest'])
+            ->getMock();
+        $httpClientMock
+            ->expects($this->exactly(3))
+            ->method('sendRequest')
+            ->willReturn($response);
+
+        $client = Client::createWithHttpClient($httpClientMock);
+
+        $api = new Issue($client);
+        $paginator = new ResultPager($client);
+        $result = $paginator->fetchAll($api, 'all', ['knplabs', 'php-github-api']);
+
+        $this->assertCount(9, $result);
+    }
+
     /**
      * @group legacy
      */