Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese translation for index.html and v1.0.0 #34

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Chinese translation for index.html and v1.0.0 #34

merged 3 commits into from
Jan 21, 2021

Conversation

LongTengDao
Copy link
Contributor

@LongTengDao LongTengDao commented Jan 17, 2021

  1. specs/cn/v1.0.0.md: Chinese translation for v1.0.0 (cheers for released!)
  2. specs/cn/v0.5.0.md specs/cn/v1.0.0-rc.1.md: correct a few my old translation while comparing for translating
  3. specs/cn/index.html: while translating, I saw toml-lang/toml.io README.md Contributing said "Translate index.html if you want"
  4. specs/en/index.html: a few typo found while translating index.html

@cannikin
Copy link
Contributor

Excellent! I found a bug in my version picker: if index.html is translated then changing your language should take you there by default, but instead it's going right to the spec.

So changing to 简体中文 should go to https://deploy-preview-34--toml-io.netlify.app/cn/ but goes to https://deploy-preview-34--toml-io.netlify.app/cn/v1.0.0 instead!

I'll open an issue to fix that, but in the meantime let's get this live!

@cannikin cannikin merged commit fbca8ac into toml-lang:main Jan 21, 2021
@cannikin
Copy link
Contributor

Opened #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants