Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the mapping of problem index to problem files less obscure #18

Open
gehring opened this issue May 26, 2020 · 1 comment
Open

Make the mapping of problem index to problem files less obscure #18

gehring opened this issue May 26, 2020 · 1 comment

Comments

@gehring
Copy link
Collaborator

gehring commented May 26, 2020

The mapping of problem index to problem files is not visible without diving into the code. Either we establish an explicit mapping of indices to pddl problem files, e.g., a yaml with a list of pddl file names or a dict of index and file names, or we keep the problem index private and remove it from the public API, e.g., replace PDDLEnv.fix_problem_index(index) with something like PDDLEnv.fix_problem(problem_filepath).

@tomsilver
Copy link
Owner

Yup agreed. I like fix_problem(problem_filepath) as an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants