New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against the previous version if HEAD === tag #16

Open

tomzx opened this issue May 10, 2015 · 0 comments

Labels

advanced enhancement

Milestone

Candidate for nex...

Owner

tomzx commented May 10, 2015

If a commit has been tagged and is the current HEAD (latest changes), then comparing it against itself is useless.

There are two ways to deal with this:

Determine that HEAD === tag and then directly output that no changes can be found since the initial and final commits are the same
Find the previous tag (prior to the given tag) and compare those. For instance, if tag=1.3.0 and HEAD is tag=1.3.0, then we should compare tag=1.2.16 against 1.3.0.

I think the second option makes more sense.

tomzx added the enhancement label

tomzx added this to the Candidate for next Minor milestone

tomzx added the advanced label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment