Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with github #23

Open
7 tasks
tomzx opened this issue Jan 21, 2016 · 1 comment
Open
7 tasks

Integrate with github #23

tomzx opened this issue Jan 21, 2016 · 1 comment

Comments

@tomzx
Copy link
Owner

tomzx commented Jan 21, 2016

Much like continuous integration (travis-ci) or code quality checkers (scrutinizer), php-semver-checker-git should integrate with github in order to provide a status report when a PR is submitted.

To do so, it appears we would need a web service to handle webhooks. Particularly, we need to handle pull request events

Then php-semver-checker-git would most likely need to call the web service when it has completed running on travis-ci.

I think the following statuses would be sent:

https://developer.github.com/v3/repos/statuses/

{
  "state": "pending",
  "target_url": "travis-job-url",
  "description": "Waiting for analysis to complete...",
  "context": "PHP Semantic Versioning Checker"
}
{
  "state": "success",
  "target_url": "travis-job-url",
  "description": "Initial semantic version: $initial<br/>Suggested semantic version: $suggested",
  "context": "PHP Semantic Versioning Checker"
}
  • Setup a web service
    • Handle push events (create a status)
    • Handle analysis completion event (update the initial status)
    • Optional The whole analysis result could be sent such that we can display the result using our own web page and do usage analytics.
  • Add an option to php-semver-checker-git to let the webservice know the analysis is done
@tomzx tomzx added this to the Candidate for next Minor milestone Jan 21, 2016
@tomzx tomzx added the advanced label Jan 24, 2016
@paulandrieux
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants