[#56] Reporter outputs an empty location if file was removed

Get the absolute path of files in the Finder. This makes it possible to strip the current working directory from the path as the full path is already resolved (which was not the case before).
tomzx · May 3, 2015 · bace13d · bace13d
1 parent 675e0b9
commit bace13d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/PHPSemVerChecker/Finder/Finder.php b/src/PHPSemVerChecker/Finder/Finder.php
@@ -28,7 +28,10 @@ public function find($path, array $includes, array $excludes = [])
 			$finder->notPath($exclude);
 		}
 
-		$files = iterator_to_array($finder->getIterator());
+		$files = [];
+		foreach ($finder as $file) {
+			$files[] = $file->getRealpath();
+		}
 
 		return $files;
 	}

diff --git a/src/PHPSemVerChecker/Reporter/Reporter.php b/src/PHPSemVerChecker/Reporter/Reporter.php
@@ -90,8 +90,7 @@ protected function getLocation(Operation $operation)
 		if ($isFullPath) {
 			$location = $operation->getLocation();
 		} else {
-			$fullPath = realpath($operation->getLocation());
-			$location = str_replace($this->cwd . DIRECTORY_SEPARATOR, '', $fullPath);
+			$location = str_replace($this->cwd . DIRECTORY_SEPARATOR, '', $operation->getLocation());
 		}
 		return $location . '#' . $operation->getLine();
 	}