feat 152 add typescript packages #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying data-visualisation with
|
| Latest commit: |
7eb6073
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b6de2bf4.data-visualisation.pages.dev |
| Branch Preview URL: | https://152.data-visualisation.pages.dev |
toni-sharpe
force-pushed
the
152
branch
4 times, most recently
from
9633024 to
72db219
Compare
* because CloudFlare doesn't accept any other npm install command and several solutions were tried I decided to move the test and build commands to pre-push and deploy the build directory directly without any build command in the CloudFlare pages settings * a strong position can be taken that this is better, no push without successful build & test keeps everything in one environment, and closes a loop for faster development
* CRA and TS, SB etc. in the npm env don't work properly, therefore TS has been reverted to the working version for CRA 5.0.1 and rebuilt for deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.