Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up execution when pinba.enabled is set to 0 #43

Open
gggeek opened this issue Dec 11, 2022 · 0 comments
Open

Speed up execution when pinba.enabled is set to 0 #43

gggeek opened this issue Dec 11, 2022 · 0 comments

Comments

@gggeek
Copy link

gggeek commented Dec 11, 2022

Atm, when pinba.enabled is set to 0, the extension code does still create timers, even though it does not flush them later on. The process of doing that does consume both cpu time (at least a gettimeofday call), and memory.

In order to minimize the impact of having one's code permanently sprinkled with pinba timer calls, it would be nice if such resource consumption was as limited as possible when pinba.enabled is set to 0.

Given that we now have the pinba.autoflush setting available to let users set up the code in a way that statistics are collected but not sent, it stands to reason that the BC break of changing the extension behaviour so that timers and tags are not created at all when pinba.enabled is set to 0 might be perceived as worthwhile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant