From a637afd4081bc256b2742b6c264cea8eefb96243 Mon Sep 17 00:00:00 2001 From: Tony Gilkerson Date: Thu, 21 Mar 2024 18:39:37 -0400 Subject: [PATCH] fix: init var outside of loop --- cmd/serial/main.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/cmd/serial/main.go b/cmd/serial/main.go index e234a09..fa40e3d 100644 --- a/cmd/serial/main.go +++ b/cmd/serial/main.go @@ -154,11 +154,12 @@ func serialServer(port *serial.Port) { buf := make([]byte, 128) log.Println("Start read loop for serial port") + var partialMsg string + for { var err error var n int - var partialMsg string log.Println("serialServer: read serial port") @@ -170,17 +171,17 @@ func serialServer(port *serial.Port) { // // messages should looks like "msg1|msg2|msg3|" and end in a | // - log.Printf("serialServer: received %v bytes: %v",n,string(buf[:n])) + log.Printf("serialServer: received %v bytes, buff: %v",n,string(buf[:n])) messages := partialMsg + string(buf[:n]) - log.Printf("serialServer: messages, is it partial - initial read? %v",messages) + log.Printf("serialServer: messages: %v",messages) // prepend the partial message from last time to the message we got this time // if we don't find a | then we still have a partial message // Add to the partial message and keep reading if !strings.HasSuffix(messages, "|") { partialMsg = messages - log.Printf("serialServer: it is partial set, set partialMsg and continue: %v",partialMsg) + log.Printf("serialServer: no terminator found, this is a partial message, set partialMsg and continue: %v",partialMsg) continue } @@ -232,6 +233,9 @@ func serialServer(port *serial.Port) { mbxRoadMainLoopHeartbeatCount.Inc() log.Println("increment mbxRoadMainLoopHeartbeatCount") + case msg == "": + // eat whitespace + default: log.Printf("No-op: %s\n", msg) }