Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy Processor M2M Generation bug #10

Open
cwdcwd opened this issue Sep 21, 2018 · 2 comments
Open

Legacy Processor M2M Generation bug #10

cwdcwd opened this issue Sep 21, 2018 · 2 comments
Assignees
@coderReview
Labels
bug Something isn't working

Comments

@cwdcwd
Copy link
Contributor

cwdcwd commented Sep 21, 2018

This line causes the M2M token to be regenerated each time. Since M2M tokens last 24hrs, this does not take advantage of the module's built in caching and refresh and hits, unnecessarily, our quota for generating tokens.

Should be a singleton in the main script
@cwdcwd
Copy link
Contributor Author

cwdcwd commented Sep 21, 2018

Legacy Processor M2M Generation bug

@cwdcwd cwdcwd added the bug Something isn't working label Sep 21, 2018
@coderReview
Copy link
Collaborator

coderReview commented Sep 21, 2018 •
edited
Loading

Fixed in 7b30454. Please try again. @cwdcwd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coderReview coderReview

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cwdcwd @coderReview